ByteArrayMessageStorage.Add: Suspicious code

[epam]

ByteArrayMessageStorage.Add: Suspicious code

[ujos]

It is not about naming. Rather about behavior. ByteArrayMessageStorage treats offset as an offset of the _originalBuffer (internal data member), while ArenaMessageStorage treats offset as an offset of the value input parameter.

Because of that I believe we cannot treat ByteArrayMessageStorage and ArenaMessageStorage classes as an instances of the same interface. I.e. you cannot replace ByteArrayMessageStorage with ArenaMessageStorage and expect correct application behaviour

[OlehVasylievEPAM]

Fix Antenna .NET Core was ported from JAVA, I think this is the reason for incorrect naming. Anyway, thank you for your feedback, we will create a ticket and fix this issue in near future.

[OlehVasylievEPAM]

Got it

[ujos]

JFYI, I worked on implementation of the FixMessage.AddTag(int, ReadOnlySpan<byte>) method. Because of this issue I cannot proceed.

[OlehVasylievEPAM]

Hello ujos, your issue is included in release 1.1.1. Please, let me know if you need a hotfix ASAP.

[ujos]

Hello ujos, your issue is included in release 1.1.1. Please, let me know if you need a hotfix ASAP.

@OlehVasylievEPAM , where can I find the code for v1.1.1 ?

[OlehVasylievEPAM]

Hello @ujos , it will be here (in the GitHub repo). For now, release 1.1.1 is only planned. Soon we release 1.1.0 with a scheduler JFYI.

[ujos]

@OlehVasylievEPAM In case if you have the hotfix ready, please share it with me.

[OlehVasylievEPAM]

@ujos, we do not have :(

[Viktar-Tserashchuk]

@ujos, it turned out that the confusing implementation of the Add method in ByteArrayMessageStorage is not used, as _origBuffer is not used to add new tags.
New tags go to ArenaMessageStorage or PerFieldMessageStorage.
Therefore, we are going to replace the Add implementation in ByteArrayMessageStorage with throwing NotSupportedException.
Pull request.

And since the current implementation of the Add method is not used, it should not block you.

[OlehVasylievEPAM]

Hi ujos, the new release (1.2.0) is available. The release contains the fix. Thanks for your impact!