Clarify intended return value for pooler:take_group_member/1, and add functionality for destroying pool groups

[epgsql]

Clarify intended return value for pooler:take_group_member/1, and add functionality for destroying pool groups

[seth]

Hi there,

The docs need updating and I will do that. An initial version used the approach of returning the pool and the pid, but I found a nicer way and that is what is implemented. So take_group_member/1 should only return the pid. Internally, pooler will track a mapping of pid -> group which is used in return_group_member/3.

I think adding a destroy_group (or for matching the existing name rm_group) is the best approach. Pooler adds each pool in a group to a pg2 group and so this can be used to quickly identify all pools in a given group and destroy them.

Would you be interested in putting together a PR with such an addition?

[TanYewWei]

Got it! I'll get to working on a rm_group function later in my day.

[seth]

Excellent :)

I've updated the docs:
fd66fdd

[seth]

merged PR #17 closing as fixed.