Giter Site home page Giter Site logo

Comments (14)

Ephigenia avatar Ephigenia commented on September 23, 2024 1

@maxkratz looks like one of the packages "csv-string" has a minor version that the one mentioned in the package.json. I’ll try to find a solution to that. Please understand that I’m new to this kind of issues.

from ikea-availability-checker.

Ephigenia avatar Ephigenia commented on September 23, 2024 1

@maxkratz thanks for testing again, I’ll look into it as soon as I can. Version 0.4.6. is the correct version.

from ikea-availability-checker.

Ephigenia avatar Ephigenia commented on September 23, 2024 1

@maxkratz that’s a known issue with a workaround in the commander package which happens when a package uses differently named sub-command executable files than the main command. That is now fixed with da8bc52

Try the new version v0.4.7 and I hope it works.

from ikea-availability-checker.

maxkratz avatar maxkratz commented on September 23, 2024

@Ephigenia Thank you for looking into this! Would you say that the error at running the stock at-command occurs because of the version mismatch?

from ikea-availability-checker.

Ephigenia avatar Ephigenia commented on September 23, 2024

@maxkratz parts of. I think you can fix the issue by updating the node version to >12.

If you’re able to update the node version that would be the preferred version. Updating and using at least LTE versions (currently node 12) would be recommended.

I might be checking all the packages and the "engines.node" entry in the package.json

from ikea-availability-checker.

maxkratz avatar maxkratz commented on September 23, 2024

@maxkratz I've upgraded to node v12.18.3, which gives me another error while installing the package:

npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":"^10.17","npm":"^6.9.0"} (current: {"node":"12.18.3","npm":"6.14.6"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]

The error at running ikea-availability stock at persists.

from ikea-availability-checker.

Ephigenia avatar Ephigenia commented on September 23, 2024

Yes, that’s right. I can confirm the problem is in the current package.json which requires "^10.17" as version which doesn’t get satisfied with the "12.18.3" caused by the "^". I’ve changed the "engine.node" version to be ">10" which now should work. Please try again with the current version of master.

from ikea-availability-checker.

maxkratz avatar maxkratz commented on September 23, 2024

First of all: I have typos in my previous comments in this issue: ikea-availability stock at -> ikea-availability store at.

I've tried two ways of installing it:

  • Without cloning the repository and installing it via npm install -g ikea-availability-checker. This gives me the same error as before.

/usr/bin/ikea-availability -> /usr/lib/node_modules/ikea-availability-checker/source/cli.js
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":"^10.17","npm":"^6.9.0"} (current: {"node":"12.18.3","npm":"6.14.6"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]

(Perhaps the change on master branch was not propagated to npm package distribution or something like that.)

  • Cloning the git repo and tried npm run start -- --help and npm run start -- stores at within the repository. This gives me the following error:

internal/modules/cjs/loader.js:968
throw err;
^

Error: Cannot find module 'commander'
Require stack:

  • /app/ikea/source/cli.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object. (/app/ikea/source/cli.js:4:15)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [ '/app/ikea/source/cli.js' ]
    }
    npm ERR! code ELIFECYCLE
    npm ERR! errno 1
    npm ERR! [email protected] start: node $npm_package_main "store" "at"
    npm ERR! Exit status 1
    npm ERR!
    npm ERR! Failed at the [email protected] start script.
    npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
    npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/2020-08-30T15_29_55_312Z-debug.log
The command '/bin/sh -c npm run start -- store at' returned a non-zero code: 1

As you probably noticed: I'm not really sure about starting the program. Am I missing something?

from ikea-availability-checker.

Ephigenia avatar Ephigenia commented on September 23, 2024

Perhaps the change on master branch was not propagated to npm package distribution or something like that.

that's what it is, I was hoping you can manage to test it without publishing a new version of the package.

Cloning the git repo and tried npm run start -- --help and npm run start -- stores at within the repository. This gives me the following error

You can install the version from master by running:

npm install https://github.com/Ephigenia/ikea-availability-checker

from ikea-availability-checker.

maxkratz avatar maxkratz commented on September 23, 2024

Okay, that makes sense to me!

I've tried the command (includig a -g) and got this output:

/usr/bin/ikea-availability -> /usr/lib/node_modules/ikea-availability-checker/source/cli.js
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10","npm":">6"} (current: {"node":"12.18.3","npm":"6.14.8"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]

  • [email protected]
    added 16 packages from 26 contributors in 5.818s
    Removing intermediate container bf44aea568f3

Does this mean, that my version of npm is too old? I think it is the most recent version out according to their page: https://www.npmjs.com/package/npm

Anyway, if I run the command to get a list of all stores in Austria, I get the following output:

root@f95270a36f46:/# ikea-availability stores at
/usr/lib/node_modules/ikea-availability-checker/node_modules/commander/index.js:925
throw new Error(executableMissing);
^

Error: 'ikea-availability-stores' does not exist

  • if 'stores' is not meant to be an executable command, remove description parameter from '.command()' and use '.description()' instead
  • if the default executable name is not suitable, use the executableFile option to supply a custom name
    at ChildProcess. (/usr/lib/node_modules/ikea-availability-checker/node_modules/commander/index.js:925:15)
    at ChildProcess.emit (events.js:315:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:273:12)
    at onErrorNT (internal/child_process.js:469:16)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

I've also tried some other variants like ikea-availability -- stores at but I don't get the desired output. Is the command the right one and can you help me with this behavior?

from ikea-availability-checker.

Ephigenia avatar Ephigenia commented on September 23, 2024

@maxkratz I’ve published a new version v0.4.5 on npm. Please try again. Sorry for the trouble.

from ikea-availability-checker.

maxkratz avatar maxkratz commented on September 23, 2024

Thank you for responses!

ikea-availability --version gives me 0.4.6, therefore the installation of the new version worked without an error:

/usr/bin/ikea-availability -> /usr/lib/node_modules/ikea-availability-checker/source/cli.js
+ [email protected]
added 16 packages from 26 contributors in 1.278s

Although the command ikea-availability stores at gives me the same error as before:

root@ae1e950ab2a1:/# ikea-availability stores at
/usr/lib/node_modules/ikea-availability-checker/node_modules/commander/index.js:925
        throw new Error(executableMissing);
        ^

Error: 'ikea-availability-stores' does not exist
 - if 'stores' is not meant to be an executable command, remove description parameter from '.command()' and use '.description()' instead
 - if the default executable name is not suitable, use the executableFile option to supply a custom name
    at ChildProcess.<anonymous> (/usr/lib/node_modules/ikea-availability-checker/node_modules/commander/index.js:925:15)
    at ChildProcess.emit (events.js:315:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:273:12)
    at onErrorNT (internal/child_process.js:469:16)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

from ikea-availability-checker.

maxkratz avatar maxkratz commented on September 23, 2024

@Ephigenia I can confirm, that it works as expected now! One sidenote: The program needs node-fetch installed. (Just in case some other people get a MODULE_NOT_FOUND-error.)

Thank you again for your work and the quick responses!

from ikea-availability-checker.

Ephigenia avatar Ephigenia commented on September 23, 2024

@maxkratz thanks for the hint, somehow i didn’t see that "node-fetch" was added as devDependency, I’ll fix that!

from ikea-availability-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.