Giter Site home page Giter Site logo

Comments (6)

kentcdodds avatar kentcdodds commented on May 29, 2024 1

Done!

Thanks for the contributions! I'm not sure how everything's going to look for the workshops by the way. I'm pretty sure I want the whole workshop to be accomplishable even if folks know nothing about TypeScript and don't specify any types. So instructions shouldn't default to using types (though they can be added in addition to the primary examples which have no types).

I don't think I'll have any instructions for adding types in the comments of the exercises either. But the final version can definitely have the types.

Still playing around with all of this. And I really appreciate you taking time to make pull requests for things! Even if I don't merge those directly, they're a great reference if I get stuck 😅

from advanced-react-apis.

kentcdodds avatar kentcdodds commented on May 29, 2024 1

I think I'm ok with this solution. If you don't mind, I'd prefer to work on this myself until I have a good feel for how I want it all to work.

You can feel free to continue making PRs if you like, but it's more likely I'd use those as references as needed than actually merge them. I appreciate your willingness to help and I hope it's been an instructional experience for you as well! Thanks for all your help!

from advanced-react-apis.

kentcdodds avatar kentcdodds commented on May 29, 2024 1

FYI, I've decided to go with a different approach. I'm going to maintain a next branch which will be the next version of the workshops. That's where I'll make all changes that I want to for the workshop (including new exercises/TypeScript/etc.). Then, when I re-record all the videos, next will become main and the old main will get a special branch for historical reasons.

I think this'll be a lot easier to manage for everyone. If someone wants to try the TypeScript stuff, they can use the next branch. They'll just have to accept that some of the code will be different from the videos until I get around to updating the videos.

from advanced-react-apis.

suddenlyGiovanni avatar suddenlyGiovanni commented on May 29, 2024

I agree.
I best the best course of action, in my opinion, would be to embrace the progressive enchantment approach;

  • convert the base setup to leverage typescript (dependencies, tsconfig, .etc)
  • maintain the exercises in JS (but also enabling them to switch to TS with zero friction)
  • maintain the final IN JS
  • provide the same finals also in Typescript.

The rationale behind it is that even developers writing JavaScript would be helped by the typescript implementation to better understand React's API, but not forced to switch to a different branch to see them.

To avoid confusion, the documentation for the typescript implementation could live within the typescript finals.

from advanced-react-apis.

kentcdodds avatar kentcdodds commented on May 29, 2024

@all-contributors please add @suddenlyGiovanni for ideas

from advanced-react-apis.

allcontributors avatar allcontributors commented on May 29, 2024

@kentcdodds

I've put up a pull request to add @suddenlyGiovanni! 🎉

from advanced-react-apis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.