Giter Site home page Giter Site logo

Comments (9)

kentcdodds avatar kentcdodds commented on July 22, 2024 1

Thanks for all the research you've done here! I don't work Fridays, but I do work Saturdays so I'll look at this today 👍

from react-suspense.

kentcdodds avatar kentcdodds commented on July 22, 2024 1

Figured it out in: https://github.com/kentcdodds/react-workshop-app/releases/tag/v3.0.2

Thanks for the report both of you!

@all-contributors please add @gkueny for bugs

from react-suspense.

gkueny avatar gkueny commented on July 22, 2024 1

thanks @kentcdodds ! All works as expected 🎉

from react-suspense.

gkueny avatar gkueny commented on July 22, 2024

Not sure if it's related but I have this Error in all the exercices

index.js:1034 Uncaught RangeError: Failed to construct 'Response': The status provided (0) is outside the range [200, 599].
index.js:1034 Uncaught RangeError: Failed to construct 'Response': The status provided (0) is outside the range [200, 599].
    at index.js:1034
    at ServiceWorkerContainer. (index.js:1200)

from react-suspense.

gkueny avatar gkueny commented on July 22, 2024

I tried to debug but I don't know the msw part well enough to understand where it goes.

I got lost in public/mockServiceWorker.js :

// l240
function sendToClient(client, message) {
  return new Promise((resolve, reject) => {
    const channel = new MessageChannel()

    channel.port1.onmessage = event => {
      if (event.data && event.data.error) {
        reject(event.data.error)
      } else {
        resolve(event.data)
      }
    }

I also tried to debug src/backend.js but it doesn't seem to reach this part of the code.

My guess is the error is somewhere in msw or @kentcdodds/react-workshop-app part but I didn't understand where the request with error 500 was going after sendToClient function

from react-suspense.

gkueny avatar gkueny commented on July 22, 2024

Ok, I found the commit that cause the issue. This is 41105a0

If I reset before this commit (go to f69de30), exercice work as expected

from react-suspense.

allcontributors avatar allcontributors commented on July 22, 2024

@kentcdodds

I've put up a pull request to add @gkueny! 🎉

from react-suspense.

kentcdodds avatar kentcdodds commented on July 22, 2024

@all-contributors please add @nawok for bugs

from react-suspense.

allcontributors avatar allcontributors commented on July 22, 2024

@kentcdodds

I've put up a pull request to add @nawok! 🎉

from react-suspense.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.