Comments (8)
don't worry about splitting - have done so.
from epinowcast.
More fleshing out process considerations: I'm also thinking in terms of the code-administrative bits (e.g. updating NEWS, dev version counter) - if this were broken in mini issues, I'd be inclined to skip those steps, and only bother with that when the whole "issue" was resolved.
To me, that leans in the direction of a single issue, but I read you re wanting to enable shorter-duration contribution efforts.
from epinowcast.
the citation bit should indicate the command to generation that content (citation("epinowcast")) and make that content more copy-paste friendly (no #> )
This is as output by citation()
but happy to hear how to improve visibility.
the equation rendering text/background doesn't inherit from user settings
Yes, this is annoying. No idea how to resolve it.
from epinowcast.
(this might be better as two issues IMO)
from epinowcast.
Re citation - just point out that it's available via citation()
(not currently mentioned - should be an easy fix) + change the formatting so that when one copies the code block, it doesn't come along w/ the prompts - that's probably a correctable artifact via some chunk option in the underlying .Rmd
For this sort of laundry list (succinctly describe-able, if not necessarily solveable in the same manner), I generally prefer an issue w/ tick boxes, rather than multiple issues linked together by a project. I'd generally see it as something solved by a single PR, with approximately one commit per tick box. Whereas the multi-issue + project approach would be solved by multiple PRs.
Do you see this one as being solved by multiple PRs?
from epinowcast.
Do you see this one as being solved by multiple PRs?
Yes
For this sort of laundry list (succinctly describe-able, if not necessarily solveable in the same manner), I generally prefer an issue w/ tick boxes, rather than multiple issues linked together by a project. I'd generally see it as something solved by a single PR, with approximately one commit per tick box. Whereas the multi-issue + project approach would be solved by multiple PRs
Fair enough. I think we want to aim for one idea per issue vs grouping issues in meta-issues if we can. Given many contributors don't have a lot of time this makes it easier for people to pick things up and solve them. In this case a PR could target both of these at once or it could not.
Re citation - just point out that it's available via citation() (not currently mentioned - should be an easy fix) + change the formatting so that when one copies the code block, it doesn't come along w/ the prompts - that's probably a correctable artifact via some chunk option in the underlying .Rmd
Agree
from epinowcast.
Agree there is a trade off but I think we probably want to aim for maximum modularity.
I'll split these out next time I'm at a computer.
from epinowcast.
Dropped equations that were being rendered incorrectly in 6e72423.
from epinowcast.
Related Issues (20)
- Set up lintr in tests HOT 1
- Review cmdstanr approach to documentation and implement good ideas here HOT 1
- Render custom stan functions using Doxygen
- DRY out vignette headers HOT 1
- enw_aggregate_cumulative throws error when using timestep=month HOT 3
- enw_aggregate_cumulative drops case counts HOT 1
- Better handle interaction between timestep and max_delay HOT 1
- Update functionality for preprocessed obs
- Expand testing for Renviron as part of persistent compiled Stan models
- Review test warnings and messages HOT 5
- Use epinowcast/actions/install-cmdstan HOT 1
- Double censoring using numerical integration HOT 1
- Figure out where extra options come from in macOS HOT 1
- Touchstone isn't working
- Checks are failing due to the ggplot2 update breaking snapshots HOT 3
- Add better visibility of contributors
- automated workflows that commit don't trigger checks HOT 10
- Linking in docs broken HOT 1
- Pkgdown enwtheme not being used HOT 8
- Incompatibility with scoringutils dev version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from epinowcast.