Giter Site home page Giter Site logo

Comments (4)

pearsonca avatar pearsonca commented on September 26, 2024 2

Seems minor.

If we did want to do this: where does the styling guidance go? Is there a static analysis / CI enforcement mechanism?

My thinking is basically that assessing the worth of these kind of changes is balancing their value (and I agree that there is some positive value to consistency here) against the cost of obtaining and maintaining that value (style guide update seems like a cheap fix, but unlikely to actually keep things in line; YAML linting CI seems expensive for just this, but perhaps there are other benefits to having that running?)

from epinowcast.

athowes avatar athowes commented on September 26, 2024 1

Fair enough: agree very minor and quite possibly a waste of time. I'm used to working on my own so still getting calibrated on scale of issues worth raising / fixing in collaborative context! Happy to close.

from epinowcast.

seabbs avatar seabbs commented on September 26, 2024

So it not being a priority for @pearsonca or me is not a reason to close as its still a issue and so we should have it for visibility if nothing else.

I think this is a great issue for a new contributor and it also suggests a new issue for the contributing guide and potentially the CI that @pearsonca is talking about (although agree that is quite a lot of engineering for minimal gain).

The key here I think is maintaining these kinds of standards can be top down or it can bee the case that you set a standard and then leave users/community to help you get coverage (which is what I think we should do here)

I've tagged this as help wanted and won't fix (i.e core devs probably won't do). @athowes if you are feeling like making a quick contribution this would be a much appreciated standardisation (also I enjoyed the open/close tag)

from epinowcast.

pearsonca avatar pearsonca commented on September 26, 2024

So it not being a priority for @pearsonca or me is not a reason to close as its still a issue and so we should have it for visibility if nothing else.

I think this is a great issue for a new contributor and it also suggests a new issue for the contributing guide and potentially the CI that @pearsonca is talking about (although agree that is quite a lot of engineering for minimal gain).

The key here I think is maintaining these kinds of standards can be top down or it can bee the case that you set a standard and then leave users/community to help you get coverage (which is what I think we should do here)

Good catch on other pro here: introductory work for people that are just starting with this package / open source contributions in general (though the CI update is definitely not light work).

from epinowcast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.