Comments (4)
Seems minor.
If we did want to do this: where does the styling guidance go? Is there a static analysis / CI enforcement mechanism?
My thinking is basically that assessing the worth of these kind of changes is balancing their value (and I agree that there is some positive value to consistency here) against the cost of obtaining and maintaining that value (style guide update seems like a cheap fix, but unlikely to actually keep things in line; YAML linting CI seems expensive for just this, but perhaps there are other benefits to having that running?)
from epinowcast.
Fair enough: agree very minor and quite possibly a waste of time. I'm used to working on my own so still getting calibrated on scale of issues worth raising / fixing in collaborative context! Happy to close.
from epinowcast.
So it not being a priority for @pearsonca or me is not a reason to close as its still a issue and so we should have it for visibility if nothing else.
I think this is a great issue for a new contributor and it also suggests a new issue for the contributing guide and potentially the CI that @pearsonca is talking about (although agree that is quite a lot of engineering for minimal gain).
The key here I think is maintaining these kinds of standards can be top down or it can bee the case that you set a standard and then leave users/community to help you get coverage (which is what I think we should do here)
I've tagged this as help wanted and won't fix (i.e core devs probably won't do). @athowes if you are feeling like making a quick contribution this would be a much appreciated standardisation (also I enjoyed the open/close tag)
from epinowcast.
So it not being a priority for @pearsonca or me is not a reason to close as its still a issue and so we should have it for visibility if nothing else.
I think this is a great issue for a new contributor and it also suggests a new issue for the contributing guide and potentially the CI that @pearsonca is talking about (although agree that is quite a lot of engineering for minimal gain).
The key here I think is maintaining these kinds of standards can be top down or it can bee the case that you set a standard and then leave users/community to help you get coverage (which is what I think we should do here)
Good catch on other pro here: introductory work for people that are just starting with this package / open source contributions in general (though the CI update is definitely not light work).
from epinowcast.
Related Issues (20)
- Improve documentation of the formula interface
- Better link model modules with model equation writeup
- Partial match of various elements in `prior` object HOT 2
- `enw_nowcast_samples()` and `enw_nowcast_summary()` give unexpected output when not working with daily time steps HOT 2
- Fix Rmd check on main HOT 1
- Implement autotest to test function inputs
- Support for fixed reporting schedule via delay probability aggregation HOT 1
- Add support for aggregation of probabilities in `expected_obs` HOT 1
- Design `structural` input to `enw_report()` for aggregating probabilties HOT 2
- Design input to the Stan code that would link user-supplied input to the aggregation argument to `expected_obs` HOT 2
- Modify `enw_report()` function documentation and add an example to `epinowcast` documentation
- Add unit/integration tests for aggregating probabilties functionality
- Update to use current function for exposing stan functions
- Explore methods with potentially better computational performance for probability aggregation in `expected_obs()` HOT 1
- Error occurs when fitting the model in: Estimating the effective reproduction number in real-time for a single timeseries with reporting delays HOT 1
- Add render-readme like actions for compiling precompiled vignettes
- Prettify and link rendered `stan` docs to website HOT 6
- QR decomposition HOT 11
- `enw_aggregate_cumulative()` doesn't count correctly when max_delay is an even multiple of the timestep HOT 1
- Revise package title HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from epinowcast.