Provisioning a new device via `equinix.metal.device` can sometimes succeed with 0 returned devices.

[equinix]

Provisioning a new device via `equinix.metal.device` can sometimes succeed with 0 returned devices.

[ischeinkman]

Actually, it looks like refresh_devices_list is correctly filtering the list of results to those matching the devices specified (by id).

Yes, that is true. What I was referring to was that refresh_devices_list only returns entries found in the list of results returned from module.get_devices(). If a devices passed in the initial devices list cannot be found in the return value of module.get_devices() then the function will not include an entry for that device ( as opposed to doing something like creating a Device object with a state of deleted/deprovisioned or something to that effect ).

Sorry that I wasn't clear!

[displague]

Thanks for reporting this @ischeinkman.

by polling the results refresh_devices_list and checking that all devices returned match their requirements, but refresh_devices_list only returns devices visible from the API without checking to see if that includes all the device IDs passed as a parameter.

Actually, it looks like refresh_devices_list is correctly filtering the list of results to those matching the devices specified (by id).

The bug here is in the "all". As a vacuous truth the condition is met. We can add a len() check to ensure that the expected number of refreshed devices are found.

>>> if all(d == 1 for d in []):
...   print("yes")
... 
yes