Lifetime of CopyableLabel can be too short under certain conditions

[eivindjahren]

Lifetime of CopyableLabel can be too short under certain conditions

[yngve-sk]

I tried to reproduce this by just running the test on Mac and it does not produce it. However... The problem might be here?

def restore_text():
    self.copy_button.setIcon(QIcon(icon_path))

Timer(1.0, restore_text).start()

This does not check if the component has been destroyed. So if the user clicks it, then within 1sec does something that destroys the component (changing views or something like that), the timer will still trigger the restore_text function, which will try to modify a now non-existing component.

Maybe just a check for this in restore_text, something like this:

def restore_text():
    if self.copy_button.isVisible():
        self.copy_button.setIcon(QIcon(icon_path))

[eivindjahren]

Maybe just a check for this in restore_text, something like this:

def restore_text():
    if self.copy_button.isVisible():
        self.copy_button.setIcon(QIcon(icon_path))

Yes, the culprit is that the timer triggers after the object is destroyed, but isVisible doesn't solve this. Probably we will have to replace timer with a slot mechanism which can be disconnected.