Giter Site home page Giter Site logo

Comments (5)

erebe avatar erebe commented on August 11, 2024

Hello :)

That's seem odd to me because query params is kind of the only way to pass information with the websocet javascript API from browser.
https://stackoverflow.com/questions/4361173/http-headers-in-websockets-client-api
https://stackoverflow.com/a/77060459

Would you mind sharing the log of wstunnel client and server with the env variable RUST_LOG=trace set ? So I can take a look at what the server receive.

If you are right, I can try to pass the info in the Sec-WebSocket-Protocol header

from wstunnel.

erebe avatar erebe commented on August 11, 2024

Would you mind trying release v8.5.0 and let me know if it works better for you ? https://github.com/erebe/wstunnel/releases/tag/v8.5.0

I now pass tunnel info into Sec-WebSocket-Protocol header

from wstunnel.

erebe avatar erebe commented on August 11, 2024

feel free to re-open if needed

from wstunnel.

BastienFaure avatar BastienFaure commented on August 11, 2024

@erebe I have done a little bit more digging and I am pretty sure it was just me that did not configure the cloudfront distribution properly (it does not forward query parameters by default).

So I guess whether you send it through a header or a query param should not make a difference.

Apologies for the overrun 😄

from wstunnel.

erebe avatar erebe commented on August 11, 2024

Hey no worries, and thanks for letting me know :)

In the end, I think passing the tunnel info inside the weboscket header protocol is more future-proof, as it is part of the spec ^^

Enjoy :)

from wstunnel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.