This package is no longer usable because "brain" library has been removed

[erelsgl]

This package is no longer usable because "brain" library has been removed

[Pierre-Gilles]

I tried to switch from brain to brain.js. It worked !

Just one issue, I ran your test, and they are not all working (even without my changes with the old brain library) =>

I don't know if you see the problem or not...

I can submit the PR without the test passing but that may not be a good idea. Maybe it may be a good moment to make everything works again :)

Thanks again for your answer,

[erelsgl]

Done, please verify *--- Erel Segal-Halevi (http://erelsgl.github.io <http://erelsgl.github.io>) אראל סגל הלוי*

…

On Sun, Feb 18, 2018 at 3:49 PM, Pierre-Gilles ***@***.***> wrote: No problem I understand, thank you very much for being that fast :) Can you bump your module version to 0.9.4, and publish a new version to NPM with this change ? :) Thx! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZPxybmtUKnCBp4qSXRhoGElpFXO23jks5tWCpSgaJpZM4SJqds> .

[erelsgl]

Dear Pierre, yes, I think this is a good idea. You are welcome to submit a PR. *--- Erel Segal-Halevi (http://erelsgl.github.io <http://erelsgl.github.io>) אראל סגל הלוי*

…

On Sun, Feb 18, 2018 at 1:54 PM, Pierre-Gilles ***@***.***> wrote: Hey ! First thank you for your awesome module :) I'm the founder of Gladys <https://github.com/GladysProject/Gladys>, an open-source home automation assistant written in Node.js. We are using limdu as a dependency, and since this week the installation of Gladys is broken because the dependency brain <https://www.npmjs.com/package/brain> that is used in limdu has been deprecated and is no longer possible to install. I saw that there is a community fork called brain.js <https://github.com/BrainJS/brain.js>, I don't know if it supports all features used in limdu, but if yes maybe limdu could switch from the deprecated "brain" to "brain.js". If you think that's a good idea, I can submit a PR to help you make this module work again :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#57>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZPxxvKCoC9vfuMA-61Jrhul6Api_KQks5tWA-GgaJpZM4SJqds> .

[erelsgl]

Thanks! I merged the PR. Regarding the failing tests - I have to check it, but currently I am overloaded with teaching duties. *--- Erel Segal-Halevi (http://erelsgl.github.io <http://erelsgl.github.io>) אראל סגל הלוי*

…

On Sun, Feb 18, 2018 at 2:23 PM, Pierre-Gilles ***@***.***> wrote: I tried to switch from brain to brain.js. It worked ! Just one issue, I ran your test, and they are not all working (even without my changes with the old brain library) => [image: capture d ecran 2018-02-18 a 13 19 55] <https://user-images.githubusercontent.com/7365207/36351742-9b4df51a-14ae-11e8-8445-4a325c7bf3cf.png> I don't know if you see the problem or not... I can submit the PR without the test passing but that may not be a good idea. Maybe it may be a good moment to make everything works again :) Thanks again for your answer, — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZPx1-n-AYiQ5SdufkMat1kauVtK51gks5tWBZYgaJpZM4SJqds> .

[Pierre-Gilles]

No problem I understand, thank you very much for being that fast :)

Can you bump your module version to 0.9.4, and publish a new version to NPM with this change ? :)

Thx!

[Pierre-Gilles]

Builds are passing again, yeaah 🤘

You're my hero of today, thanks a lot for being so reactive :)

Thank you from the whole Gladys community 🙂

[robertleeplummerjr]

You guys rock. Any bugs found in brain.js, let us know.