Be able to find chia command without activating the env

[ericaltendorf]

Be able to find chia command without activating the env

[altendky]

Will probably need to tweak the $PATHfor the subprocess to include the scripts path so chia itself can still subprocess as needed. I'm not sure if they are consistently using sys.executable or the scripts path or such for their own needs.

[13thProgression]

It seems dangerous to try to modify the requirements of chia to make plotman more approachable. I understand the intent, but if chia changes how they initialize their software it could leave plotman broken. Perhaps a more verbose error if the env isn't activated?

[altendky]

There's no need to modify chia. And it is entirely proper for Python programs to be usable without activating the environment. Basically all activating the virtual environment does is add the env/bin/ directory to your PATH so that the Python and other programs there will be found.

[altendky]

Oh, and chia already works fine in my experience without activating the environment.

[13thProgression]

At the moment, this is true. My point was more that the chia project provides guidelines for how to start plots. Circumventing those guidelines might work at the moment, but any change on the chia project side can break this in the future. Conforming to their current guidelines is like conforming to an API: no guarantee of future compatibility, but higher likelihood.

I don't think this change will reduce confusion for new users. This may be convenient for experienced users that always update chia in the same location. However, could cause issues for users that update chia in a new path before deleting the old one (to reduce downtime in the event that something goes wrong with the new version.)

Don't mean for this to sound negative about the potential change, just trying to enumerate a few possible unintended consequences.

[altendky]

Perhaps you have opinions about priorities and configurability of this? I think configurability could be good including allowing hardcoding a path to the chia to use. For defaults, at the moment it seems like searching PATH first is reasonable for backwards compatibility and allowance of env activation, when the user chooses to do it, to have the (theoretically) intended effect and take priority. Then second, look in the plotman env.

Note that plotman is going to be importing chia to use the chia code to parse plot command lines. Yes, this increases the coupling between the two. But, we've had numerous people having lots of different issues with this and rewriting a command line parsing isn't obviously a good choice. Yes, we may also end up copying the chia cli definition code into plotman to change the coupling (reduced in some ways, increased in others). At the end of the day, they are coupled and chia doesn't presently provide an api. Anyways, env/bin/pip install plotman[chia] will be a reasonable option for simple startup in many cases (never all) without git cloning anything etc. It seems useful for the result to work with or without activation.