Giter Site home page Giter Site logo

Comments (2)

ericelliott avatar ericelliott commented on June 12, 2024

There's no need for the user to store the hash as an object. It works great as-is storing it as a string (simple key-value pair in any datastore), unless you see a potential attack in the way we handle JSON?

from credential.

tjconcept avatar tjconcept commented on June 12, 2024

There could be minor advantages like querying for passwords with too few iterations and similar, but it is not worth the breaking change when the work-around is so simple (JSON.parse/stringify on the user-side). Also it would make it less simple, which is not desirable for this API.

I have considered this myself earlier and is just leaving my notes/findings here for future-Thomas to revisit when I forget;

  • verify could accept an object in a backwards compatible fashion
  • hash can not easily return an object (maybe using a prototype with toString method - but too risky and hack-ish)
  • support for this would require a new/redundant "hash" method returning an object

from credential.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.