Accessing actions from custom middleware

[ericelliott]

Accessing actions from custom middleware

[bognix]

I would like to propose an alternative

What user provides is this array of states, actions and transitions:

  ['initialize', 'idle',
    ['fetch', 'fetching',
      ['cancel', 'idle'],
      ['report error', 'error',
        ['handle error', 'idle']
      ],
      ['report success', 'success',
        ['handle success', 'idle']
      ]
    ]
  ]
];

and I like how the actionCreators maps state transitions to methods.

If I understand correctly what you are proposing David is to have the same structure in actions so calling actions.handleSuccess would return string value.

How about combining those two and instead of having both actionCreators and actions do something like this:

    handleSuccess: {
        creator: () => {},
        name: "NAME"
    },
    ...
}

On the other hand, I don't like adding another level of nesting and it seems reasonable to just import { handleSuccess, handleError} from './myActionCreators' and then simply call it without accessing nested creator. With this in mind I'm leaning toward David's idea which doesn't include additional nesting but I'm posting above as the food for thought.

[ericelliott]

Merged. Will look at releasing the change with a major version bump soon.

[ericelliott]

You mean we should expose action type constants as an object with original labels as keys? That's not a bad idea. PR?

[dash-]

@ericelliott #20

[dash-]

Awesome thanks :-)

[ericelliott]

Published as 2.0.0