panDelta variable not initialized - Clang Static Analyzer warning

[erichoracek]

panDelta variable not initialized - Clang Static Analyzer warning

[fcanas]

Have you observed any ill behavior because of this?

self.possibleDrawerDirection cannot be clear on both the horizontal and vertical directions. If so, the behavior is completely undefined. You'd be patching an analyzer warning, but not actually correcting behavior. It may be more correct to assert that possibleDrawerDirection must have either horizontal or vertical components.

[Timac]

I am testing MSDynamicsDrawerViewController and I haven't see any ill behavior yet.

When I evaluate source code, I always run the Clang Static Analyzer on it before doing anything else. When I see source code containing hundreds of memory leaks or other analyzer warnings I know the code is bad and it is not worth looking at it.

Regarding the issue, I would initialize panDelta to 0.0 to make sure there is no undefined behavior and to avoid the analyzer warning. I haven't looked at 'self.possibleDrawerDirection' but having an assert for undefined cases is always good.

[erichoracek]

Fixed in 1.3.2.