Remove OnConfiguring from generated Context

[erikej]

Remove OnConfiguring from generated Context

[ErikEJ]

Good suggestion, but you can just use the constructor that takes an optionsbuilder

[MgSam]

The constructor is public DbContext(DbContextOptions options), so it is doesn't give access to the builder.

[ErikEJ]

I meant DbContextOptions that you can build externally..

[r3faat1]

@ErikEJ Can you give an example of what you mean? I ran into the same problem. I would have a partial class that generates OnConfiguring, however, every time I run EF Power Tool, the generated file gets OnConfiguring added again.

So, you're saying, I could just do public DbContext(DbContextOptions options) on my non-generated partial file and configure my options there? If done so, optionsBuilder.IsConfigured will be set to true on OnConfiguring?

[ErikEJ]

Just add:

public DataContext(DbContextOptions<DataContext> options)
            : base(options)
        {
        }

(This is automatically included in the latest daily build)

[MgSam]

@ErikEJ I'm still not following how that is equivalent to allowing us to override OnConfiguring ourselves. Are you suggesting doing this?

//In partial class...

//User-defined constructor
public MyContext() : this(getOptions()) { }

private static DbContextOptions getOptions()
{
    var builder = new DbContextOptionsBuilder();
    //Do something here with builder
    return builder.Options;
}

That seems like a lot of plumbing for people to write just to get to an DbContextOptionsBuilder.

The OnConfiguring method generated by the handlebars template is literally useless- I don't understand why it exists or why you can't just remove it.

[ErikEJ]

Whoa? Why do you mention Handlebars now?

[ErikEJ]

Please provide a sample project, and indicate if you were using Handlebars or not.

[MgSam]

@ErikEJ I think you are missing the point- why does OnConfiguring exist in the generated code?

It does literally nothing, except make this tool less useful because the user cannot provide their own implementation.

Handlebars has nothing to do with it- the output is the same is the same with or without it. I have included handlebar templates in my project only so that I can remove the generated OnConfigured method. I've made no other changes to the templates.

[ErikEJ]

I assume you have selected the option to remove the connection string?

[ErikEJ]

The generated DbContext (not using HandleBars) has this constructor:

   public DataContext(DbContextOptions<DataContext> options)
        : base(options)
    {
    }

Which allows you to construct a context like this from outside the generated code:

    public DataContext Create(string connectionString = null)
    {
        var optionsBuilder = new DbContextOptionsBuilder<DataContext>();
        optionsBuilder.UseInMemoryDatabase(_guid);
        var context = new DataContext(optionsBuilder.Options);
        return context;
    }

[ErikEJ]

Closing but a well tested PR for this will be accepted