Comments (1)
Yes, the diagonal values in the correlation matrix should be 1. I have compared my methods to the corresponding numpy implementations, and the scaling factor in calculating the correlation matrix should have been 1/N instead of 1/(N-1) (used in calculating the covariance matrix).
The latest commit fixed this.
> import numpy as np
> from data_operation import *
> x = np.array(np.random.random((10, 4)))
> calculate_correlation_matrix(x)
array([[ 1. , 0.18390596, 0.34851226, 0.83499889],
[ 0.18390596, 1. , 0.27027579, 0.44432891],
[ 0.34851226, 0.27027579, 1. , 0.52136316],
[ 0.83499889, 0.44432891, 0.52136316, 1. ]])
> np.corrcoef(x, rowvar=0)
array([[ 1. , 0.18390596, 0.34851226, 0.83499889],
[ 0.18390596, 1. , 0.27027579, 0.44432891],
[ 0.34851226, 0.27027579, 1. , 0.52136316],
[ 0.83499889, 0.44432891, 0.52136316, 1. ]])
> calculate_covariance_matrix(x)
array([[ 0.11678785, 0.019298 , 0.0229638 , 0.07239497],
[ 0.019298 , 0.09428342, 0.01600117, 0.03461353],
[ 0.0229638 , 0.01600117, 0.03717523, 0.02550297],
[ 0.07239497, 0.03461353, 0.02550297, 0.06436463]])
> np.cov(x, rowvar=0)
array([[ 0.11678785, 0.019298 , 0.0229638 , 0.07239497],
[ 0.019298 , 0.09428342, 0.01600117, 0.03461353],
[ 0.0229638 , 0.01600117, 0.03717523, 0.02550297],
[ 0.07239497, 0.03461353, 0.02550297, 0.06436463]])
from ml-from-scratch.
Related Issues (20)
- Project dependencies may have API risk issues
- Nestrov Accelerated Gradient Descent HOT 1
- Linear Regression Regularization bias HOT 1
- (A doubt NOT an issue) Gradient of loss function having different sign after performing first-degree differentiation of LogisticLoss
- Naive Bayes
- python setup.py install does not work on Windows 10
- Missing number of neurons in grad_w for dense layer
- Error in MLP HOT 1
- BN layer and dropout
- why LassoRegression need X = normalize(polynomial_features(X, degree=self.degree)) code in LassoRegression class?
- Implementations
- ModuleNotFoundError: No module named 'mlfromscratch'
- Linear Discriminant Analysis HOT 1
- TypeError: make_blobs() got an unexpected keyword argument 'n_smaples'
- Adam mhat and vhat updates
- can you add code for intercept /bias to regressions HOT 1
- How to save the model? HOT 2
- No lambda, gamma for XGBoostRegressionTree?
- cross entropy is correct? HOT 2
- ML from scratch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ml-from-scratch.