support for className?

[tarlepp]

support for className?

[eriktufvesson]

Support for className is now added.

<button class="btn btn-lg btn-primary"
        ng-bootbox-title="A cool title!"
        ng-bootbox-custom-dialog="Some custom text"
        ng-bootbox-buttons="customDialogButtons"
        ng-bootbox-class-name="some-class">
    Custom dialog
</button>

[tarlepp]

First of all thanks for this!

I was wondering if more "common" solutions would be helpful for this kind of problems. Eg. when someone notices next not supported option value that is needed, again you need to make some changes for supporting that.

How about "common" ng-bootbox-options="customOptions" that are just merged to actual bootbox dialog, alert, confirm, etc. What do you think about this?

Also it would be very nice, if you linked those commits to each issue, so it's easier to see actual changes of each issue.

[eriktufvesson]

Hi again,

Sorry for the late reply. Thanks for pointing out that I should reference
the issues in my commits. I'm kind of new to Github and this is my first
open source project.

I have now added a ng-bootbox-options parameter to the custom dialog. You
can use it like this:
https://gist.github.com/eriktufvesson/d388ea4a44da2ec5548f

I have also added a setDefaults method to the $ngBootbox factory.

To my knowledge, you can't specify specific options for the alerts,
confirms and prompts in bootbox. However, the setDefaults apply to those.
Please correct me if I'm wrong, but I can't find anything on this matter in
the API Docs.

Best regards
Erik

2014-12-10 20:15 GMT+01:00 Tarmo Leppänen [email protected]:

First of all thanks for this!

I was wondering if more "common" solutions would be helpful for this kind
of problems. Eg. when someone notices next not supported option value that
is needed, again you need to make some changes for supporting that.

How about "common" ng-bootbox-options="customOptions" that are just merged
to actual bootbox dialog, alert, confirm, etc. What do you think about this?

Also it would be very nice, if you linked those commits to each issue, so
it's easier to see actual changes of each issue.

—
Reply to this email directly or view it on GitHub
#5 (comment)
.