Timeout with jobs monthly R16B02

[erlware]

Timeout with jobs monthly R16B02

[stuartT4]

Maximum allowed timeout in erlang is 4294967295 which is 2^32 -1.

This is however 49 days if I am calculating it correctly.

Which led me to 4835019000 which is approximately 56 days.

[stuartT4]

The problem is that this month is 12th i.e. December and the code would always add one year and set month to one more however I am attempting to for example set a cronjob for the 26th of this month, but it sets it to next month.

My fix is to re-write the function to the following. This fixes multiple issues.

until_next_time(State, {{monthly, DoM, Period}, _What}) ->

{{ThisYear, ThisMonth, Today}, _} = current_date(State),

Days = case calendar:date_to_gregorian_days(ThisYear, ThisMonth, DoM)  - calendar:date_to_gregorian_days(ThisYear, ThisMonth, Today) of
    Res when Res < 0 ->
            {NextYear, NextMonth} =
            case ThisMonth of
                12 ->
                    {ThisYear + 1, 1};
                _  ->
                    {ThisYear, ThisMonth + 1}
            end,
            D1 = calendar:date_to_gregorian_days(ThisYear, ThisMonth, Today),
            D2 = calendar:date_to_gregorian_days(NextYear, NextMonth, DoM),
            D2 - D1;
   Ds ->
       Ds
end,

[Santiniis]

Closing this as we're dropping the support for older releases of OTP