Comments (9)
From @esheldon:
under region=="weight" you have
wt_us = wt
seems a bit misleading, maybe that should be None?
from ngmixer.
Note the previous is in simpsimmedsio.py
from ngmixer.
Also monkey patching can be problematic
from ngmixer.
In simpsimmedsio
_get_band_observation(..):
...
obs.weight_us = wt_us
The above is what I mean by monkey patching
from ngmixer.
Yeah totally agree. Just hacking things up so it runs for now. Def need to clean up when the whole thing gets refactored.
from ngmixer.
Design-wise, not sure if it makes sense to add set_usweight() etc. though. Maybe this belongs in the meta dictionary, which is explicitly a grab-bag?
from ngmixer.
Right. So in terms of design, the reason that I am mucking with the weights in the first place is because the MOF expects two weights. The first is for the initial iteration of the fitting and the second is for the subsequent ones. This happens to be uberseg, but actually a more general interface to the MOF should be provided. Something like initial_weight
and iter_weight
or whatever.
from ngmixer.
Maybe a new datastructure is needed, designed for MOF.
This could either take an Observation/Obslist/ etc. on construction or inherit from one of those.
With a new data type you can apply constraints/requirements to make sure you have what you want without resorting to monkey patching Observations.
from ngmixer.
closing this in favor of #25
from ngmixer.
Related Issues (20)
- add more MOF flags
- pixel masking borken for MOF HOT 3
- epoch data is buggy
- change bsub commands to support change in queue
- change slac submission scripts to use LSF tmp dir
- make nbrs rending use fast approx exp
- update medsio class to read wcs headers from new meds format
- delete metacalwcs branch
- update handling of image flags in medsio classes
- build class to create corrected MEDS files
- fix logsb for logpars HOT 1
- fix mag calculation for log pars
- Change COADD_OBJECT_ID HOT 3
- Python 3 imports HOT 1
- MOF files assumed to have griz when using `correct_meds` option HOT 2
- join error in get_meds_files HOT 1
- nbrs_data extension sometimes missing from MOF output files
- use segmentation map to perform extractorcorrector ? HOT 6
- don't use flag value 2**30 in the bmasks
- make sure to always zero the weight map in extractor corrector
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngmixer.