Giter Site home page Giter Site logo

Comments (3)

lomaxfrog avatar lomaxfrog commented on June 13, 2024

Agree. I think the questions are:
1 - do we need a default directory, or, should ENOS just fail at boot time if ENOS_HOME is not defined ?
2 - if we decide on having a default directory, the current directory is almost just as bad as /tmp. The source directory would also be bad.

+1 to have ENOS fail if there is not defined ENOS_HOME, and remove all default (including in scripts)

from enos.

bmah888 avatar bmah888 commented on June 13, 2024

We need to be careful about this...ENOS_ROOT isn't the same as ENOS_HOME. I think we're both thinking about the root directory (where the data lives) as opposed to the home directory (where the code lives).

Anyways. We have the rootDirectory option in the configuration file to control this. Currently the default is /tmp/enos (and this in fact is how that directory gets defined on a fresh-out-of-the-box install). I can take the default out and force the admin / developer / whoever to define this in a configuration file. Or we can figure out some sensible default and put that in instead. (See base/enos.json.default for more details.)

The difference is if we do the former (no default), we're sacrificing the ability to run enos without any prior configuration. On the other hand if we do the latter (pick a default), that directory needs to be created by the admin before running ENOS for the first time anyway, so that still requires some effort. If we do the latter, at least they don't need to actually create enos.json, they just need to make the directory, so I'm gently leaning towards that direction.

I could go either way on this, and we can certainly change it later if we go one way and decide it didn't work.

from enos.

lomaxfrog avatar lomaxfrog commented on June 13, 2024

Or, what we could do, is to define a default directory, prompt the user to accept or change it the first time it runs ENOS and the dir is not configured.

from enos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.