[cocos2dx] Double free warning in Spine Examples

[TyelorD]

[cocos2dx] Double free warning in Spine Examples

[TyelorD]

I found a potential work around. I can make a pull request for this fix, if it's deemed appropriate and bug free.

My change is as follows, in Debug.h change the definition of DebugExtension::_readFile to:

virtual char *_readFile(const String &path, int *length) {
    auto data = _extension->_readFile(path, length);
    
    if (_allocated.count(data) == 0) {
        _allocated[data] = Allocation(data, sizeof(char) * (*length), nullptr, 0);
        _allocations++;
        _usedMemory += sizeof(char) * (*length);
    }
    
    return data;
}

I will note that this doesn't add the FILE or LINE values to the Allocation struct, since I wanted to avoid making changes outside of Debug.h.

[badlogic]

The warning is actually correct. While Atlas calls the extension, the extension itself is not allocating this memory. It's Cocos2D-x that loads the file and allocates the in-memory buffer for its contents.

See https://github.com/EsotericSoftware/spine-runtimes/blob/4.2/spine-cocos2dx/spine-cocos2dx/src/spine/spine-cocos2dx.cpp#L134-L150

That said, the warning no longer really serves a purpose, as that part of the runtime has been thoroughly tested. I've applied your change. Thanks!