`espup install` expects `/bin/bash` to exist

[esp-rs]

`espup install` expects `/bin/bash` to exist

[SergioGasquez]

Just created #161 with @joshuachp patch (thanks for sharing it!), I did some testing and everything was working for me. Please, @frantisekhanzlikbl can you confirm that this fixes your issue?

cargo install espup --git https://github.com/SergioGasquez/espup --branch fix/bash
espup install

[frantisekhanzlikbl]

Hey, so sorry for taking forever to reply. I was using the ESP for a short-lived school project, so I haven't had the chance to try it again yet. I unfortunately can't test the fix ATM, but it looks exactly like what I've done locally to make it work, which did fix the issue.
Thanks so much for working on this!

[SergioGasquez]

Hi!

Sorry for taking so long to reply. I've just had a look at the issue, but for some reason, the cmd! macro does not work without a bash path. I've improved the current state a bit: main...fix/bash-path
But still not ideal, I've also seen that you did some testing, did you have more success than me?

[joshuachp]

Hi, I manage to run espup on nix with the following nix package:

{ pkgs
, lib
, rustPlatform
, fetchCrate
}:

rustPlatform.buildRustPackage rec {
  pname = "espup";
  version = "0.2.6";
  patches = [ ./bash.patch ];

  src = fetchCrate {
    inherit pname version;
    sha256 = "sha256-+G/0Eo1/IULoa3EQmn2CYUzqyQ2iXnFtyUBfzwJNMp4=";
  };

  cargoSha256 = "sha256-lmyeK3Wj/q1uNw4iROuaHkjfBxvXtktK3e3y5GytbXg=";

  nativeBuildInputs = with pkgs;[
    pkg-config
    perl
  ];
  buildInputs = with pkgs; [
    openssl
  ];

  # A test will fail since will try to make a http request
  doCheck = false;

  meta = with lib; {
    description = "Tool for installing and maintaining ESP Rust ecosystem.";
    homepage = "https://github.com/esp-rs/espup";
    license = with licenses; [ asl20 mit ];
  };
}

The patch needed was the following: bash.patch

Hope this helps, it would be great to make it work on NixOS.

EDIT: This won't work since the installation will later fail while installing the rust toolchian