Giter Site home page Giter Site logo

Comments (8)

Esqarrouth avatar Esqarrouth commented on August 11, 2024

Have you done any experiments with this?

What could be changed to make this work? Because I don't normally use storyboards I don't have good ideas to fix this.

from ezloadingactivity.

Sweeper777 avatar Sweeper777 commented on August 11, 2024

Which view is the superview of EZLoadindActivity? You should set the superview of EZLoadingActivity to be the current view controller's view

from ezloadingactivity.

Esqarrouth avatar Esqarrouth commented on August 11, 2024

In that case when you are loading something, and the view changes behind, there are bugs and weird stuff happening. If you can catch them and fix them then feel free to send a pull request

from ezloadingactivity.

Sweeper777 avatar Sweeper777 commented on August 11, 2024

I fixed it! Since I am quite new to github, I don't know how to create a Pull Request. I'll tell you where to change.

In EZLoadingActivity.swift line 108:

center = CGPoint(x: UIScreen.mainScreen().bounds.midX, y: UIScreen.mainScreen().bounds.midY)

Change the above line to

center = CGPoint(x: topMostController!.view.bounds.midX, y: topMostController!.view.bounds.midY)

And it should work on modally presented view controllers now. For the master detail views, I haven't found a solution yet.

from ezloadingactivity.

Sweeper777 avatar Sweeper777 commented on August 11, 2024

I forgot to mention, the midX in the above code comes from the midX implementation in EZSwiftExtensions.

from ezloadingactivity.

Esqarrouth avatar Esqarrouth commented on August 11, 2024

Oh, you just go inside the file and click edit, then click the big button at bottom to send a pull request.

Will this affect normal loading activities? Which aren't presented modally?

from ezloadingactivity.

Sweeper777 avatar Sweeper777 commented on August 11, 2024

Just in case you didn't get the notification for pull requests.

from ezloadingactivity.

Esqarrouth avatar Esqarrouth commented on August 11, 2024

Thanks 👍

from ezloadingactivity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.