Review code

[esri]

Review code

[jcfranco]

• Some variables are typed as any. E.g., defaultConfig, defaultSettings

• Need to use declared decorator, as shown here, for creating classes.

• locale, under Properties section, should be typed as string to be consistent with other properties.

• Some promise-result types can be narrowed down instead of using any.

• Properties from settings can be renamed using deconstruction:

  const { environment: environmentSettings, group: groupSettings, /* ... */ } = settings;

• This and this can be simplified by not checking for length.

• Private methods can be extracted into separate utilities

• Some conditional logic can be simplified:

  const isEsriAppsPath = esriAppsPathIndex !== -1; // `? true : false;` not needed

• Typo: _foramatUrlParamValue -> _formatUrlParamValue

• ApplicationBaseItemPromises and Direction could be moved to interfaces.d.ts

Minor

• Rename:
  • RTLLocales -> rtlLocales
  • _setupCORS -> _setUpCORS
  • webmapX -> webMapX/websceneX -> webSceneX
  • _queryItem -> _loadItem? (applies to others too)
  • ptl -> portal and type as any when setting helperServices
• checkSignIn can be dropped
• New line after property name headers

[driskull]

👍 thanks!! I'll work on these

[driskull]

Updated with: 44e9695

Thanks @jcfranco!

I'll think about how I can move more functions into separate modules. I don't want these functions to be documented so maybe a support module that starts with an underscore?

[jcfranco]

I don't want these functions to be documented so maybe a support module that starts with an underscore?

👍 Although, I think you could still split them up without the underscore.

[driskull]

I got all the TypeScripty things updated