Feature request: context instead of timeouts

[essentialkaos]

Feature request: context instead of timeouts

[andyone]

Hi! Thanks for detailed feature request.

It's hardcoded to 10 seconds at

It's a public variable with default timeouts and can be changed from your code as well. Also, you can configure API.Client after creating a new API struct. So there is a lot of customization options.

In case if the caller side does not want results anymore - no need to retain resources (memory and sockets) for more than necessary, and make the caller wait for up to extra 10 seconds.

DoDeadline does not accept context, only time.Time with Deadline date and time. So you can't cancel your request. Could you please clarify your idea behind using context?

[andyone]

I have a little bit changed working with request timeout in the new version. In the last version, RequestTimeout type changed to time.Duration, and we use this value with DoTimeout method. Also, it makes it easier to change the timeout for API instance through RequestTimeout property.

[zerkms]

Oh, I'm not sure how it happened that I misread time.Time with context.Context 🤦