Panic when decoding images

[sxyazi]

Panic when decoding images

[etemesi254]

Thank you @uklotzde for the suggestion, I thought I had added a testcase but was for another problem.

Added in 2128376

Also fixed this in 0.5.0-rc0 which is now up in crates.io So closing this.

Thank you for reporting

[uklotzde]

Hi, is it possible to release a 0.4.12 version that removes this assert? I ran into it on this seemingly valid image

This would be a low effort quick fix to resolve the issue temporarily. Clients will handle the subsequent decoding error gracefully.

Many downstream dependencies that have upgraded to image v0.25.x are affected. Crashing applications for no valid reason is very inconvenient.

[uklotzde]

...especially now since image v0.25 is actively promoted: https://www.reddit.com/r/rust/comments/1cj94va/image_v025_performance_improvements/

[etemesi254]

working on it, sorry for the crash, it just happens that it was reported when i was overhauling the api and couldn't hot fix it

[zphixon]

Hi, is it possible to release a 0.4.12 version that removes this assert? I ran into it on this seemingly valid image

(I promise I didn't mess with this image on purpose to trigger this. I've had it floating around since 2020 😅)

[uklotzde]

How about adding a regression test for this case? To ensure that this does not happen again in the future.

[rohitmittapalli]

Bump on releasing a 0.4.12 update to resolve this! Happy to help here and update the image crate as needed.