Comments (5)
Merged in latest release!
from seo.
Fixed it my adding $path = strtok($path, '?'); to public function findRedirectByPath ($path)
from seo.
Would you like me to fork the project and push the solution
from seo.
Yeah that'd be great, thanks!
from seo.
I'm encountering this issue still on the latest Craft 2 release. At least if this is the use case:
- Set up a redirect from /abc to /xyz
- Navigate to /abc?ctm_tracking_code=9929292929
- 404 (expected to go to /xyz)
I was able to fix it by adding some code to Seo_RedirectService.php
$qs = array();
preg_match('/\?.*/', $path, $qs);
$path = preg_replace('/\?.*/', '', $path);
if (trim($redirect['uri'], '/') == $path)
{
$to = (count($qs)>0) ? $redirect['to'] . $qs[0] : $redirect['to'];
}
Not the most elegant but it works. I'm on an older version than the latest Craft 2 release so the code may not be exactly the same but I did confirm the issue on the latest as well.
from seo.
Related Issues (20)
- Focus keywords fields not working HOT 2
- Environment check for production always returns false if ENVIRONMENT is not set HOT 21
- Noindex issue with new google search console HOT 4
- [FR] support label localization
- Changing the title configuration doesn't work HOT 1
- Default Social Image (not available when allowAdminChanges set to no) HOT 1
- Can't delete Redirect [Error] Error: Call to a member function delete()
- [FR] Mastodon HOT 2
- Saving a title token as blank
- Keywords are not rendered in template HOT 2
- Abandoned HOT 9
- Redirects Page Returns 500 Error
- Craft error message do not support (or parse) html
- Plugin store displays message: This plugin is no longer maintained. HOT 1
- Settings saved in project config HOT 2
- Spacing bug between page title and site name HOT 3
- Below is a rendering of the page up to the first error HOT 1
- Possible remote file inclusion
- Default page description in settings & entries are different HOT 7
- og:url and twitter:url referencing Blitz cache token HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seo.