attempting to encode bytes of wrong size produces a misleading error message

[ldct]

attempting to encode bytes of wrong size produces a misleading error message

[stefanmendoza]

The reason this is thrown is because is_address calls is_binary_address:

https://github.com/ethereum/eth-utils/blob/v2.0.0-alpha.0/eth_utils/address.py#L23-L32

Since that method checks whether the passed in address is bytes and valid length, there would be no way to discern from the response of is_address what actually caused it to be False, just that it didn't pass the validation. And since str type works for hexstrings:

>>> from eth_account.account import Account
>>> import eth_abi
>>> acct = Account.create()
>>> acct.address; type(acct.address)
'0x73445e747C4103638F84d9D91e7b01239599D7e5'
<class 'str'>
>>> eth_abi.encode_single('address', acct.address)
b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00sD^t|A\x03c\x8f\x84\xd9\xd9\x1e{\x01#\x95\x99\xd7\xe5'

I don't think we can just add an is_bytes check here.

[pipermerriam]

I'm thinking something like this:

if not is_address(value):
    if is_string(value):
        raise EncodingTypeError("Unable to parse {0} as an address.  Supported formats are ...")
    else:
        raise EncodingTypeError("Cannot encode value of type {0} as an address")