Comments (8)
A patch was put up for this, but it appears there is still a bug with it:
// Inside /src/lib/utils/editPath.ts, we return:
join(EDIT_CONTENT_URL, CONTENT_DIR, relativePath, "index.md")
EDIT_CONTENT_URL
has https://
at the beginning of it... we cannot pass this to join()
because that function will collapse repeating slashes (/
) down to only one, as it's forming a path.
We should use construct a URL with new URL(path, base)
instead and return the href
value from the resulting object, passing join(CONTENT_DIR, relativePath, "index.md")
as the path
argument, and EDIT_CONTENT_URL
as the base
... this will properly parse these into a URL.
ie. (new URL(join(CONTENT_DIR, relativePath, "index.md"), EDIT_CONTENT_URL)).href
@HiroyukiNaito Assigning you for this =)
from ethereum-org-website.
It seems that this has already been fixed but not deployed to production
from ethereum-org-website.
If it is not fixed, I would like to work on the issue.
from ethereum-org-website.
@wackerow
Is it fixed? If not, I doubt it is caused only by SSG. Is there any way to build same as ethereum.org SSG for locating the cause?
from ethereum-org-website.
@wackerow Thanks for the tips! I work on it.
from ethereum-org-website.
Hey @HiroyukiNaito! Thanks for offering to patch this... Just want to mention that this bug is somewhat important since it's breaking all the edit links in the docs. We were hoping to get this patched ASAP...
Any chance you're able to make this patch in the next few hours? Otherwise I may put up a patch so we can hot-fix the deploy planned for later today. Sorry for the time crunch ๐
from ethereum-org-website.
Hey @HiroyukiNaito, apologies for jumping in on this, but given the nature of this bug we wanted to get a patch up for this ASAP... I put up a PR to fix, but thank you for offering to help!
from ethereum-org-website.
@wackerow Sure, thanks for notifying that!
from ethereum-org-website.
Related Issues (20)
- OKX HOT 2
- TradeCoinVN Cแปng ฤแปng Crypto
- Bug report: Refactoring by using The Nullish Coalescing Operator (??) in settings files
- RANDAO explanation in Node Architecture page
- Contradiction between smart contract accounts and wallets
- Charts on the homepage in mobile break on some languages HOT 2
- Missing Images in README.md File HOT 1
- Update USDC link on stablecoin.tsx HOT 5
- Previous & Next Button in Developer Documentation shows wrong link HOT 1
- Replace, rename and remove unavailable URLs on ethereum.org's DeSci page HOT 3
- Add EthCC 2024 to events HOT 4
- Sybil attack as a glossary item
- Setup texts for translation (2)
- Language resources ABC order
- Chart text without overlapping HOT 4
- Bug: missing space in history entries HOT 6
- Feedback on glossary
- Adding ValleyDAO to the Desci page's Get Involved List HOT 3
- [typo link] - roadmap ethereum magician link is redirected from a figma link HOT 5
- [email protected]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ethereum-org-website.