Comments (14)
Hey @konopkja, I'm interested in working on this issue
from ethereum-org-website.
Hi @saurabhburade, thats exciting! I will assign you the issue then! :) Thank you
from ethereum-org-website.
I have rough preview ready as of now
from ethereum-org-website.
So this needs to be figured out, which event to promote at top, or maybe have a separate metadata
ok since items are pulled from other sources as well, for now i think lets ship MVP without editor's choice functionality
from ethereum-org-website.
As a workaround, I'm using import { Image } from "@chakra-ui/react"
from ethereum-org-website.
@konopkja Thank you for assigning the issue, I wanted to know what's the Editors choice
, maybe I can add the first event on the list available.
from ethereum-org-website.
Thanks @saurabhburade!
Many of our events are pulled from an external spreadsheet. The details of the logic can be found inside src/scripts/events/ethereum-events-import.ts
... The EthereumEventsImport()
function is called inside src/scripts/events-import.ts
and results assigned to ethereumEvents
... These objects here should have an imageUrl
property which we're currently not doing anything with... This is not the case for events added separately to this API import, but I would start there and we can figure out a process to get images for other events separately.
from ethereum-org-website.
@konopkja Thank you for assigning the issue, I wanted to know what's the
Editors choice
, maybe I can add the first event on the list available.
its an idea for new type of event that should be more promoted, for example devcon or devconnect. You would have to create new metadata field for it i assume.
from ethereum-org-website.
@konopkja Thank you for assigning the issue, I wanted to know what's the
Editors choice
, maybe I can add the first event on the list available.its an idea for new type of event that should be more promoted, for example devcon or devconnect. You would have to create new metadata field for it i assume.
do not add first event, this should be manual choice
if no event has it, do not show this section and title
from ethereum-org-website.
So this needs to be figured out, which event to promote at top, or maybe have a separate metadata
from ethereum-org-website.
Sounds great!
One thing to be noticed and need help on is that we cannot load external images directly on nextjs and need to whitelist these domains/hostnames through with images that are coming.
I need help to understand what to do with external image URLs?
from ethereum-org-website.
Sounds great!
One thing to be noticed and need help on is that we cannot load external images directly on nextjs and need to whitelist these domains/hostnames through with images that are coming. I need help to understand what to do with external image URLs?
from ethereum-org-website.
One thing to be noticed and need help on is that we cannot load external images directly on nextjs and need to whitelist these domains/hostnames through with images that are coming. I need help to understand what to do with external image URLs?
Good point... I'm not sure allowlisting will be a sustainable path forward here. We may want to consider iterating on the GitHub action/workflow that pulls in these events to also download and add the event images directly to our repo so we avoid these issues. cc: @pettinarip, thoughts?
from ethereum-org-website.
This issue is stale because it has been open 30 days with no activity.
from ethereum-org-website.
Related Issues (20)
- Delete /enterprise/private-ethereum/ and the menu link to it HOT 4
- Content request: ETH issuance - how many ETH are there? HOT 7
- Bug report: remove date from whitepaper page HOT 9
- Add a quiz for DEFI page HOT 3
- Add quiz for stablecoins HOT 5
- Content request: What is cryptocurrency and blockchain? HOT 4
- Content request: Ethereum payments as a use case
- Content request: best design practices for wallets (UX/UI)
- Content request: Smart contract design and UX
- Add Linea to displayed layer 2s HOT 2
- Suggest a wallet HOT 1
- Suggest a wallet: MEW Portfolio HOT 3
- Remove StatsBoxGrid stories
- Design request: redesign dapps page HOT 1
- Suggest a wallet: Looping Smart Wallet HOT 1
- **Release Notes Persisted**
- Updating ShapeShift Wallet - ERC20 Token Import
- Suggest a wallet: MEW Mobile HOT 1
- Updating "Figment" to show a green check for Self Custody
- Feature request : Introduce new faucets list page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ethereum-org-website.