on db nuke also nuke kademlia metrics

[darkobas2]

on db nuke also nuke kademlia metrics

[notanatol]

Currently the kademlia-metric folder is removed during nuking. The issue is that during 'hot' db nuke it's impossible to be sure that the running process will not impede the folder from being removed and that can result in a corrupted database.

We can only insist to not execute the nuke command on a running instance.

[ldeffenb]

IIRC, a bee node will generate some sort of locking error if it tries to use a data-dir that is in use by another instance. Any chance that approach could be used on the db nuke command?

[notanatol]

IIRC, a bee node will generate some sort of locking error if it tries to use a data-dir that is in use by another instance. Any chance that approach could be used on the db nuke command?

So it seems that in the case of the kademlia instance the removal can succeed, it's not deterministic. But when it fails (removes partially) it leaves the database in an inconsistent state. A custom locking mechanism can be implemented but we have to look into the (effort invested)/reward ratio.