Giter Site home page Giter Site logo

Use traits instead. about baum HOT 5 CLOSED

etrepat avatar etrepat commented on July 17, 2024
Use traits instead.

from baum.

Comments (5)

etrepat avatar etrepat commented on July 17, 2024

I understand the benefits of composition over inheritance where they're applicable.

The main problem I have with coding Baum as a trait or with a collection of traits is PHP 5.3.x compatibility. If Laravel/Eloquent are compatible with PHP 5.3.x so should be a package designed for them.

If your object model is not too complex though, I don't see why you couldn't extend Baum (as you'd probably have extended Model with Eloquent anyway) and "compose/mix" in your business logic with traits.

from baum.

atrauzzi avatar atrauzzi commented on July 17, 2024

That's probably not the best assumption to make as you're not the first library I've recommended switch to traits that has had this response.

So, in theory, each library is now competing to be the "base class". Can't be all of them, so which will it be?

Also, FWIW, PHP 5.3 is EoL, not much point in worrying about it anymore. All in all, seems like a losing battle.

from baum.

etrepat avatar etrepat commented on July 17, 2024

I understood your point.

There's no "one size fits all" solution to this. So I'm making a compromise here for the sake of being as close to Eloquent's requirements as possible, at least right now.

There's some important features I'd like to have implemented before moving the requirements forward. Thanks for the suggestion, though.

from baum.

deanmraz avatar deanmraz commented on July 17, 2024

@etrepat can you revisit this request?

Laravel 4.2 is using traits for Eloquent's soft deleting feature: http://laravel.com/docs/4.2/eloquent#soft-deleting

from baum.

jcwatson11 avatar jcwatson11 commented on July 17, 2024

+1 for revisiting this issue. Converting to a trait would allow a lot more flexibility for all.

from baum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.