Comments (5)
I understand the benefits of composition over inheritance where they're applicable.
The main problem I have with coding Baum
as a trait or with a collection of traits is PHP 5.3.x compatibility. If Laravel/Eloquent are compatible with PHP 5.3.x so should be a package designed for them.
If your object model is not too complex though, I don't see why you couldn't extend Baum (as you'd probably have extended Model
with Eloquent
anyway) and "compose/mix" in your business logic with traits.
from baum.
That's probably not the best assumption to make as you're not the first library I've recommended switch to traits that has had this response.
So, in theory, each library is now competing to be the "base class". Can't be all of them, so which will it be?
Also, FWIW, PHP 5.3 is EoL, not much point in worrying about it anymore. All in all, seems like a losing battle.
from baum.
I understood your point.
There's no "one size fits all" solution to this. So I'm making a compromise here for the sake of being as close to Eloquent's requirements as possible, at least right now.
There's some important features I'd like to have implemented before moving the requirements forward. Thanks for the suggestion, though.
from baum.
@etrepat can you revisit this request?
Laravel 4.2 is using traits for Eloquent's soft deleting feature: http://laravel.com/docs/4.2/eloquent#soft-deleting
from baum.
+1 for revisiting this issue. Converting to a trait would allow a lot more flexibility for all.
from baum.
Related Issues (20)
- Call to undefined method Illuminate\Events\Dispatcher::fire() in Laravel 5.8 HOT 6
- Not working with laravel 5.8 HOT 6
- Method Illuminate\Database\Eloquent\Collection::insideSubtree does not exist.
- Cannot use a string as custom key for eloquent model in v2.x-dev HOT 1
- Cannot create multiple tree in the same table by using buildTree
- Cannot create multiple tree in the same table by using buildTree HOT 1
- Please update for Laravel 5.8 HOT 4
- Installation in Laravel 6 not working HOT 18
- Call to undefined method `immediateDescendants()`
- Column not found: 1054 Unknown column 'table.left' in 'order clause' HOT 2
- Not working function with soft delete items HOT 1
- Call to a member function getKeyName() on null
- Support Laravel 7? HOT 3
- Please add Laravel 7 support! HOT 6
- Unresolvable dependency resolving [Parameter #1 [ <required> $customStubPath HOT 2
- Change default key from `id` to another column
- Rebuild doesn't check alias for parent_id HOT 1
- How to do if category has many parent categories?
- not supported php 8.0 HOT 4
- See comment for php 8 and laravel 8 supported version of this project
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baum.