Giter Site home page Giter Site logo

Comments (3)

etrepat avatar etrepat commented on August 15, 2024

Yes. The isset() there can be error prone because it returns false even when the value is NULL. I'll prepare a patch to change that check to use the isDirty() function.

Thanks for spotting this & providing a possible approach for a solution.

p.s. I don't quite follow the second existance/root checks. In which case makeRoot()fails?

from baum.

AngryUbuntuNerd avatar AngryUbuntuNerd commented on August 15, 2024

Thanks for that. The second check in brackets ensures that new elements [ !$this->exists() ] without parent_id [ $this->isRoot() ] dont get set as root again. This is being done already by Node.php/setDefaultLeftAndRight() via creating-event.
Otherwise the same happens like in ticket #56

from baum.

etrepat avatar etrepat commented on August 15, 2024

Merged the changes.

Thanks.

from baum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.