Exporting is broken

[etro-js]

Exporting is broken

[clabe45]

Hello, thanks for such a detailed write-up! I have been too busy to work on this project lately, but if you want to submit a pull request, I would be more than happy to merge it!

[eboujlal]

Can you please do a pull request so can CLABE add yours to the main code ?

[clabe45]

@saltukkos What error or problem did you receive, and what did you expect? Can you also please provide some sample code that causes the problem?

[saltukkos]

@clabe45 I just tried to run the example with recording. (As I can remember, it's https://github.com/clabe45/vidar/blob/master/examples/introduction/export.html)
In any browser I tried (Chrome, new Edge, Yandex Browser, Opera on Android), the demo didn't work. Player didn't show any video after recording. After some investigation I found, that it would record something if I disable audio by passing {audio:false} (of course audio would not be recorded). After deeper investigation I found that empty blob was produced because of absence of sound in the recorder in any case. The workaround I found is described in the issue (connect the source to the result of actx.createMediaStreamDestination()), but I'm not sure it's the valid way to go, so, I don't want to make a pull request.

[clabe45]

Okay, thank you. I had to create a solution that was a bit more complex, because the audio node graph had to remain intact when we both start and stop recording. This involved spying on connect and disconnect in the media layer class (as can be seen in acefaad).