All programs fail to compile with serial lib in nim 1.0

[euantorano]

All programs fail to compile with serial lib in nim 1.0

[euantorano]

Thanks for the report, I’ll have a look after work tonight and push a patch.

…

On Thu, 26 Sep 2019, at 01:27, Adam Caldwell wrote: All programs are failing to compile with nim 1.0.0 with the following error: `/home/snip/.nimble/pkgs/serial-1.1.2/serial/serialstream.nim(117, 17) Error: type mismatch: got <proc (s: Stream, buffer: pointer, bufLen: int): int{.gcsafe, locks: <unknown>.}> but expected 'proc (s: Stream, buffer: pointer, bufLen: int): int{.gcsafe.}' .raise effects differ` The only thing needed to trigger this error on compilation is a one line test file: `import serial` — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#22?email_source=notifications&email_token=AAFW24IAK6SW77LS3UDBQELQLP6VTA5CNFSM4I2TOEIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNX2FHA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24P3MJ2WMW47TSSWCVLQLP6VTANCNFSM4I2TOEIA>.

[euantorano]

I've just tested this and I can't reproduce the issue on Nim Compiler Version 1.0.0 [MacOSX: amd64]. Can you post the output of nim -v so I can see what platform you're on?

I have found another issue that affects compatibility with v1.0.0 though.

[accaldwell]

Nim Compiler Version 1.0.0 [Linux: amd64]
Compiled at 2019-09-23
Copyright (c) 2006-2019 by Andreas Rumpf

git hash: f7a8fc46c0012033917582eb740dc0343c093e35
active boot switches: -d:release

Installed using choosenim on Arch Linux.

[euantorano]

Thanks, I’ll need to test on a Linux system. You should be able to `import serial/serialport` for now hopefully.

…

On Sat, 28 Sep 2019, at 19:45, Adam Caldwell wrote: `Nim Compiler Version 1.0.0 [Linux: amd64] Compiled at 2019-09-23 Copyright (c) 2006-2019 by Andreas Rumpf git hash: f7a8fc46c0012033917582eb740dc0343c093e35 active boot switches: -d:release` Installed using choosenim on Arch Linux. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22?email_source=notifications&email_token=AAFW24PVIHMNB7RWJUSUWSTQL6Q3DA5CNFSM4I2TOEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7277WI#issuecomment-536215513>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24PBHKAIP36UOD55TG3QL6Q3DANCNFSM4I2TOEIA>.

[accaldwell]

Yeah, unfortunately the code I'm writing uses serial/utils and serial/serialstream also.

FYI, this seems broken as far back as 0.20.0, but 0.19.6 works fine on my test machines.

[euantorano]

I’m. I think I had a report about it before but couldn’t reproduce it then either. I’ll set up a Linux machine and test today. By any chance are you using —threads:on or anything?

…

On Tue, 1 Oct 2019, at 01:30, Adam Caldwell wrote: Yeah, unfortunately the code I'm writing uses serial/utils and serial/serialstream also. FYI, this seems broken as far back as 0.20.0, but 0.19.6 works fine on my test machines. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22?email_source=notifications&email_token=AAFW24K6WMPD3Y3ELOA6JUTQMKKZXA5CNFSM4I2TOEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD77QJWI#issuecomment-536806617>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24MRPCEYHK6ILLEQBO3QMKKZXANCNFSM4I2TOEIA>.

[accaldwell]

Hmm, actually it looks like this was fixed as part of #21. I was testing with version 1.1.2 as installed by nimble (the latest release version), which didn't include that fix. nimble install serial@#head installs a version that works.

[euantorano]

I’ll create a new release today and see if that helps nimble.

…

On Tue, 1 Oct 2019, at 05:37, Adam Caldwell wrote: Closed #22 <#22>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22?email_source=notifications&email_token=AAFW24OQN423HLIWKJJUIG3QMLHZRA5CNFSM4I2TOEIKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT55BLAQ#event-2675578242>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24MD4Q5XFGTYZFNGERLQMLHZRANCNFSM4I2TOEIA>.

[PMunch]

I ran into the same issue today, also with 1.1.2. Did you create a new release?

[euantorano]

@PMunch 1.1.3 was released recently. There have been a few changes since then, and I'm planning to tag a new release once I fix #25 and #26.

I'd advise using HEAD for now until a new release is tagged.

[PMunch]

Ah, you forgot to tag that release with a git tag which is what I believe nimble uses to get versions. So it installs 1.1.2 by default.

[euantorano]

Yep, seems like it. I'm sure Nimble used to just use the .nimble file, but I know you have to try and keep the 2 in sync which is a bit of a pain.