Fix for CRLF issue when working repo on linux/mac

[evanplaice]

Fix for CRLF issue when working repo on linux/mac

[evanplaice]

From [email protected] on October 29, 2012 21:02:32

What's the big deal? Line endings are nothing but window dressing anyway... The code works fine without them and we're not fancy enough to use carriage returns here? /s

I'm kidding. It's probably jumbling the code for you because all of the development on jquery-csv happens in linux (which uses lf not crlf). I'm also using Notepad++ (via WINE) so it should be trivial to batch convert everything to crlf.

I'll let you know as soon as the source is ready.

Status: Accepted
Labels: -Priority-Medium Priority-Low

[evanplaice]

From Thanpolas on October 30, 2012 11:19:21

Actually my issue is with git, not my ide...

I have my git configured so as to convert crlf to lf, which is the default setting on most unix based machines.

This causes each checkout, to have uncommitted changes by default.

Adding the ".gitattributes" file, fixes that.

However, yea it would be a good idea to convert all to LF

[evanplaice]

From [email protected] on October 30, 2012 16:58:49

Go figure. I made the switch to Notepad++ on linux because I'm not a vim/emacs monkey and all the rest of the editors suck. As a result, half of the project files use CRLF, the other half use LF.

The project-wide convention is LF. I had to add an additional line-conversion commit to the repo but everything should be consistent now.

Quick question, you're saying the following setting sets all line endings to lf on commit?

Set default behaviour, in case users don't have core.autocrlf set.

• text=crlf

[evanplaice]

From Thanpolas on October 31, 2012 02:16:49

The .gitattributes file helps ignore the crlf issue.

If you want it to force normalization then it's better you see this article: http://git-scm.com/book/en/Customizing-Git-Git-Configuration#Formatting-and-Whitespace

[evanplaice]

From [email protected] on October 31, 2012 22:54:03

OK, thanks for clarifying.

I'll add the .gitattributes to ensure that I don't accidentally add crlf to any documents I create in the future (as git should notify where any inconsistencies occur).

I'd like to say that this is an uncommon issue but it's not the first time I have encountered it. At least, now I have a workable solution.

Thank you for the feedback.

[evanplaice]

From [email protected] on October 31, 2012 22:54:22

Status: Verified

[evanplaice]

From [email protected] on November 04, 2012 15:03:07

Owner: [email protected]