Giter Site home page Giter Site logo

Comments (4)

danburzo avatar danburzo commented on June 3, 2024

Hi @marcelpi, thanks for logging the issue.

You are right that achromatic colors in lch() and oklch() will not have an h component (as technically it can be any value), so when serializing to CSS you need to account for that, or alternatively use culori.formatCss(lchColor).

A separate issue is that interpolatorSplineMonotone doesn't seem to notice that the hue is undefined for some of the colors and uses it in computations, resulting in NaN. This is worth investigating.

from culori.

marcelpi avatar marcelpi commented on June 3, 2024

Thanks for your answer, @danburzo.
I think that the h component can be interpolated as any other without omitting it, or just default it to 0.
Other spaces consider hsl(12 0% 0%) and hsl(323 0% 0%) as black even though there is a hue.

But I also understand your perspective, my guess is this would also solve the interpolatorSplineMonotone issue.

from culori.

danburzo avatar danburzo commented on June 3, 2024

In Culori, an undefined value for a component denotes a missing component, which in CSS can be specified by the author with the none keyword. For example, { mode: 'lch', l: 50, c: 50 } is represented in CSS as lch(50% 50 none).

Interpolating a color with lch(50% 50 none) is different from interpolating it with lch(50% 50 0).

Here's Chrome rendering linear-gradient(to right, blue, lch(50% 50 none)). Note that the missing hue picks its value from the blue color.

Screenshot 2023-06-01 at 20 49 17

Here is the same gradient, but with hue = 0: linear-gradient(to right, blue, lch(50% 50 0)).

Screenshot 2023-06-01 at 20 49 27

Interpolation with missing components is described here.

I will need to investigate which conversions make the wrong assumptions and produce NaN.

from culori.

marcelpi avatar marcelpi commented on June 3, 2024

Alright, makes sense. Thanks for clearing that out.

from culori.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.