.net core issues when using function on mac

[EricZimmerman]

.net core issues when using function on mac

[PrzemyslawKlys]

Well, I just did a small test

Write-Color test,test -Color Red,Yellow
Write-Color test,test2 -Color Red,Yellow,White
Write-Color test,test

All works fine. The error on your screen says "Cannot proces the color because -1 is not a valid color". Maybe you're passing Color as variables or something? Alternatively, provide some test case that fails?

[EricZimmerman]

Download this script and run it It exhibits the issue https://f001.backblazeb2.com/file/EricZimmermanTools/Get-ZimmermanTools.zip I even had a user add a check that of $defaultcolor is -1 set it to Grey but same error.

…

On Sun, Jun 30, 2019, 9:54 AM Przemysław Kłys ***@***.***> wrote: Well, I just did a small test Write-Color test,test -Color Red,Yellow Write-Color test,test2 -Color Red,Yellow,White Write-Color test,test All works fine. The error on your screen says "Cannot proces the color because -1 is not a valid color". Maybe you're passing Color as variables or something? Alternatively, provide some test case that fails? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=ABARKJTZN6OZUS4F67VGEGDP5C3IVA5CNFSM4H4MNG6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4MULA#issuecomment-507038252>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABARKJUBXJ4DMJH7WNJ6K2LP5C3IVANCNFSM4H4MNG6A> .

[PrzemyslawKlys]

On MacOS

(get-host).ui.rawui  

returns -1 for foregroundcolor and for bacckgroundcolor, hence your problem.

Also why would you need Write-Color if you're using Write-Host all over the place ?:-)

Write-Host ""
Write-Host "This script will discover and download all available programs" -BackgroundColor Blue
Write-Host "from https://ericzimmerman.github.io and download them to $Dest" -BackgroundColor Blue
Write-Host "`nA file will also be created in $Dest that tracks the SHA-1 of each file,"
Write-Host "so rerunning the script will only download new versions."
Write-Host "`nTo redownload, remove lines from or delete the CSV file created under $Dest and rerun. Enjoy!`n"

Could be replaced with:

Write-Color "This script will discover and download all available programs" -BackgroundColor Blue
Write-Color "from https://ericzimmerman.github.io and download them to $Dest" -BackgroundColor Blue -LinesAfter 1
Write-Color  "A file will also be created in $Dest that tracks the SHA-1 of each file,"
Write-Color "so rerunning the script will only download new versions."
Write-Color -LinesBefore 1 -Text "To redownload, remove lines from or delete the CSV file created under $Dest and rerun. Enjoy!" -LinesAfter 1

Also it's Gray not Grey, maybe that's why?

[PrzemyslawKlys]

Also

Write-Host ""
write-color -Text "* ", "Saving downloaded version information to $localDetailsFile" -Color Green,Red
Write-host "`n"

Can be replaced with single line:

write-color -Text "* ", "Saving downloaded version information to $localDetailsFile" -Color Green,Red -LinesBefore 1 -LinesAfter 1

[EricZimmerman]

Yes I haven't finished pulling all the old wite-host calls out. I like how your code allows for color vs write-host as well

…

On Sun, Jun 30, 2019, 10:08 AM Przemysław Kłys ***@***.***> wrote: Also Write-Host ""write-color -Text "* ", "Saving downloaded version information to $localDetailsFile" -Color Green,RedWrite-host "`n" Can be replaced with single line: write-color -Text "* ", "Saving downloaded version information to $localDetailsFile" -Color Green,Red -LinesBefore 1 -LinesAfter 1 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=ABARKJQFUDXCMM7DEL6NL7DP5C46RA5CNFSM4H4MNG6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4M4WA#issuecomment-507039320>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABARKJROYWPMGH2BSJSYXPLP5C46RANCNFSM4H4MNG6A> .

[EricZimmerman]

As I said I added a check like this after assigning default color If defaultcolor == -1 defaultcolor = grey And assuming my end user saved things properly, it didn't fix it This is why I created the issue because I couldn't see anywhere else it could have happened from what I've looked at so far. I may just set defaultcolor to grey and be done with it

…

On Sun, Jun 30, 2019, 10:05 AM Przemysław Kłys ***@***.***> wrote: On MacOS (get-host).ui.rawui returns -1 for foregroundcolor and for bacckgroundcolor, hence your problem. Also why would you need Write-Color if you're using Write-Host all over the place ?:-) Write-Host "" Write-Host "This script will discover and download all available programs" -BackgroundColor Blue Write-Host "from https://ericzimmerman.github.io and download them to $Dest" -BackgroundColor Blue Write-Host "`nA file will also be created in $Dest that tracks the SHA-1 of each file," Write-Host "so rerunning the script will only download new versions." Write-Host "`nTo redownload, remove lines from or delete the CSV file created under $Dest and rerun. Enjoy!`n" Could be replaced with: Write-Color "This script will discover and download all available programs" -BackgroundColor BlueWrite-Color "from https://ericzimmerman.github.io and download them to $Dest" -BackgroundColor Blue -LinesAfter 1Write-Color "A file will also be created in $Dest that tracks the SHA-1 of each file,"Write-Color "so rerunning the script will only download new versions."Write-Color -LinesBefore 1 -Text "To redownload, remove lines from or delete the CSV file created under $Dest and rerun. Enjoy!" -LinesAfter 1 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=ABARKJVYDCUESI74722I3JLP5C4SXA5CNFSM4H4MNG6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4M2ZQ#issuecomment-507039078>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABARKJWBSSVIU5FRGEMBV4TP5C4SXANCNFSM4H4MNG6A> .

[PrzemyslawKlys]

$TestColor = (Get-Host).ui.rawui.ForegroundColor
if ($TestColor -eq -1) {
    $defaultColor = [ConsoleColor]::Gray
} else {
    $defaultColor = $TestColor
}

The only thing that comes to my mind is that the user didn't save it properly. The -1 had to come from somewhere and that's the only place I see. The other reason would be that you were trying to save Gray color to $TestColor which was -1 and type of int at that point. You can try above and see if it works.

[EricZimmerman]

i found it strange the mac set the colors to -1 at all. i will test out the code and finish porting the write-host calls. thanks for your help and nice function