Giter Site home page Giter Site logo

Comments (4)

poemm avatar poemm commented on June 15, 2024

Maybe you already know this, but the Wasm spec requires host functions to return with the type in their signature (or never return if they are in an infinite loop). So perhaps you can return in a way which triggers a Wasm trap, which allows Wasm to handle the trap and exit cleanly. This can be optimized later.

from ewasm-rust-api.

axic avatar axic commented on June 15, 2024

-> ! is added because it was made with the assumption that ewasm/design#72 is merged

Since it is not merged, we probably should remove those atm.

from ewasm-rust-api.

axic avatar axic commented on June 15, 2024

Here's a generated code example (from sha256 precompile):

 (func $_ZN9ewasm_api6revert17h4611de01ad540c7bE (; 74 ;) (type $7)
  (call $ethereum_revert
   (i32.const 0)
   (i32.const 0)
  )
  (unreachable)
 )

-> ! means the function never returns, and it seems that Rust enforces this in the wasm output as including a trap after the function.

While this would be unnecessary since the function would never return anyway, it is a nice behaviour to ensure a non-compliant VM fails 😉

I'd really prefer to merge ewasm/design#72 and keep 😕

from ewasm-rust-api.

axic avatar axic commented on June 15, 2024

Since the design issue was decided on and ewasm/hera#249 was merged, this can be closed.

from ewasm-rust-api.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.