Comments (4)
Maybe you already know this, but the Wasm spec requires host functions to return with the type in their signature (or never return if they are in an infinite loop). So perhaps you can return in a way which triggers a Wasm trap, which allows Wasm to handle the trap and exit cleanly. This can be optimized later.
from ewasm-rust-api.
-> !
is added because it was made with the assumption that ewasm/design#72 is merged
Since it is not merged, we probably should remove those atm.
from ewasm-rust-api.
Here's a generated code example (from sha256 precompile):
(func $_ZN9ewasm_api6revert17h4611de01ad540c7bE (; 74 ;) (type $7)
(call $ethereum_revert
(i32.const 0)
(i32.const 0)
)
(unreachable)
)
-> !
means the function never returns, and it seems that Rust enforces this in the wasm output as including a trap after the function.
While this would be unnecessary since the function would never return anyway, it is a nice behaviour to ensure a non-compliant VM fails 😉
I'd really prefer to merge ewasm/design#72 and keep 😕
from ewasm-rust-api.
Since the design issue was decided on and ewasm/hera#249 was merged, this can be closed.
from ewasm-rust-api.
Related Issues (16)
- Write tests for the API functions HOT 2
- Documentation
- Add a set of helpers to acquire "entire" external data
- Publish documentation on gh-pages using circleci HOT 4
- Use no_std
- Add rustdoc to type aliases
- Introduce higher level data types
- Use wee_alloc by default
- Implement "primitive allocator" which never frees HOT 3
- Turn ewasm_api into a trait HOT 4
- Cleaning up "features" HOT 2
- Create a macro for the entry point
- Turn the debug feature into a macro
- consider adding a `main` function to `src\main.rs` HOT 2
- Split log into log0/log1/log2/log3/log4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ewasm-rust-api.