Issue using exercism tool to get the go exercises

[exercism]

Issue using exercism tool to get the go exercises

[kytrinyx]

What does exercism debug output?

[davidsulpy]

It turns out I had not yet set my api key. It would be nice if the error message had showed me that it was an issue because I had no api key set. Once I ran exercism configure --key=KEY and then ran exercism fetch go leap everything worked just fine. If I'd followed the directions better I wouldn't've run into this issue, but at least it's still a potentially valid user experience issue.

Thanks for the quick response though!

Also, just for the sake of completion, here was the exercism debug output prior to me setting my key:

**** Debug Information ****
Exercism CLI Version: 2.2.1
Exercism CLI Latest Release: 2.2.1
OS/Architecture: darwin/amd64
Build OS/Architecture /
Home Dir: /Users/davidsulpy
Config file: <not configured>
API Key: <not configured>
API: http://exercism.io [connected]
XAPI: http://x.exercism.io [connected]
Exercises Directory: /Users/davidsulpy/exercism

If you are having trouble and need to file a GitHub issue (https://github.com/exercism/exercism.io/issues) please include this information (except your API key. Keep that private).

[kytrinyx]

It turns out I had not yet set my api key.

Aaah, yes we should absolutely give you a good error message for that!

/cc @exercism/cli-committers should we check this at the CLI level, or should the API take care of it and provide a better error message?

[Tonkpils]

@kytrinyx I may lean towards checking this at both the CLI and the API level, but if not, the API definitely needs to at least handle returning error responses as JSON. We could also make the error messages on unmarshal better. The user doesn't really care about the JSON being unable to be parsed. It's simply an error on our end and to provide the debug info as an issue. Thoughts?

[kytrinyx]

I may lean towards checking this at both the CLI and the API level

Agreed.

API definitely needs to at least handle returning error responses as JSON

Yeah, definitely.

We could also make the error messages on unmarshal better.

Yeah, let's do that, as well.

It's simply an error on our end and to provide the debug info as an issue.

You mean add the output on STDERR but as "extra information" that can be submitted in an issue, if they care to?

[lcowell]

I'm thinking it's best to let the api provide us with an error rather than enforcing it at the cli interface. The cli's job is to send up whatever it can, it's the server's job to decide if that good enough.

I think about the discussion here exercism/exercism#2607 and the possibility of an anonymous fetch from the cli. We don't really need an api_key to do a fetch and it would mean we only have to make a change in one place if we want to change the rules.

Not needing an api key could be a way of removing barriers to trying exercism out.

[kytrinyx]

Oh, right, I forgot about the anonymous fetch thing. That's a better rule in any case.

We still need to make sure the API always sends JSON, not sure how the HTML slipped in there. I'll take a look at this tomorrow.

[kytrinyx]

I'm deploying a fix for this right now.