Recommend a linter in the getting started page for Ruby

[kytrinyx]

Recommend a linter in the getting started page for Ruby

[markijbema]

I think it would be the most appropriate. I'm a bit weary of suggesting people should only submit rubocop validated code; for instance, I think it's worthwhile to have a discussion about quoting style (I get nitpicked all the time about this; I actually use my own convention for this, which I think is worthwhile, and find interesting to discuss to see what others see). Or to give another example, this would conflict with the Weirich block style.

Maybe it would be better to suggest rubocop along with a exercism approved 'minimum' config? I'm sure everyone agrees we should indent 2, not 4 spaces.

[kytrinyx]

Yeah, for Ruby I think that the value of linting is consistency within a team, and a discussion about why you prefer one way over the other. I don't think there should be any sort of style guide (aside from the aforementioned 2 spaces for indentation).

I've never used rubocop, so I don't know how easy it is to turn rules on and off.

[markijbema]

You can configure this with a yaml file. You can also easily take an existing codebase (say the current examples), run rubocop on them, and automatically generate an ignore file for all rules which weren't followed.

[kytrinyx]

I'm not sure I want to suggest a default set of styles per se, only suggest that people experiment with rubocop to see what it can do for them, and perhaps suggest some styles they might try (or point to a good blog post on the matter).

[markijbema]

Ah yes, that would be a good idea. You can probably point them towards https://github.com/bbatsov/ruby-style-guide now, since it allows multiple interpretations of controversial issues. Then maybe add how they can generate a config they like with --autogen-config

[kytrinyx]

Perfect.

[kotp]

As far as style goes, I think the sentiment you brought up elsewhere was "I want people to say 'Look at Exercism as a source of great style and clarity.'" (which is paraphrased, as I don't remember the exact quote), and so Rubocop as a tool for this to promote standards convention is a good thing. So for the tests, I think using Rubocop to enforce style is a good thing, with the freedom, of course, to ignore those 'cops' based on judgement for the authors. For those participating and learning, it is good to leave the discussion point open for style. (Even tabs vs spaces vs 2 spaces vs 4 or 6 || 8 spaces).

[kytrinyx]

Agreed, the consistency would be useful here.

[kotp]

Also merged #60 so thinking this should be closed as an issue?

[kytrinyx]

Thanks!