Comments (8)
kytrinyx
commented on June 25, 2024
Nice catch. Would you be willing to submit a patch for the test suite? https://github.com/exercism/xruby
from ruby.
vitoreiji
commented on June 25, 2024
I just submitted a pull request addressing this issue. Let me know if there's anything I should improve before it can be merged.
from ruby.
cbojar
commented on June 25, 2024
Don't we also need begin and end delimiters so it doesn't accept something like "asdsdvfverAD234dsghs./,!"?
from ruby.
kytrinyx
commented on June 25, 2024
Yeah, it would be good to have tests agains that case.
from ruby.
vitoreiji
commented on June 25, 2024
Hey, thanks!
I comitted the suggested changes to my fork. Not sure how to proceed now, this is my first time updating a pull request.
Cheers!
from ruby.
kytrinyx
commented on June 25, 2024
If you submitted changes to your fork, the PR will automatically be updated. Thanks!
from ruby.
britishtea
commented on June 25, 2024
I think this issue can be closed, since #36 is closed as well.
from ruby.
kytrinyx
commented on June 25, 2024
Yepp, good catch, thanks.
from ruby.
Related Issues (20)
- Kindergarten Garden may be harder than defined HOT 4
- [SavingAccounts]: Suggestion: change negative interest rate tests to return positive value HOT 5
- Hacktoberfest 2022 HOT 2
- Binary Search Ruby HOT 3
- TwoBucket - possible error in test suite HOT 4
- Question about function name in "Moviegoer" exercism HOT 2
- Typo in final bird_count test where "whith" should be "with" HOT 2
- Typo in locomotive_engineer instrucions HOT 2
- Locomotive Engineer exercise relies on implicit Ruby behavior HOT 1
- the pythagorean triplet exercise has something wrong with it HOT 1
- Add analyzer for leap HOT 2
- Armstrong exercise tests confusion HOT 7
- 🤖 Sync error for commit 3312f6 HOT 1
- The Symbols document contains a factual error. HOT 2
- Building a training set of tags for ruby HOT 22
- Should the Attendee query methods end in a question mark? HOT 2
- Issue with savings_account interest_rate test HOT 2
- Parallel Letter Frequency times out in the web interface HOT 3
- Correction: Conditional concept document introduction.md HOT 2
- Insufficient test cases in `house` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby.