gigasecond: use times (not dates) for inputs and outputs

[kytrinyx]

gigasecond: use times (not dates) for inputs and outputs

[kotp]

When converting to Time, 46 minutes 40 second (approximately) discrepancy.

Compared to former tests, I mean
.

[kytrinyx]

That sounds like daylight savings time. Is the Time in UTC or a local timezone?

[kotp]

Daylight savings would not be off by 46 minutes, though. An hour, maybe, as that is what DST does, but , it sounds like minute and second leaps. Date class handles things like that, time class, not so much, from what I understand.

[kytrinyx]

A billion seconds, he told us, equals 31 years, 259 days, 1 hour, 46 minutes and 40 seconds.

I don't know if the Date tests are correct or the Time ones. I would have thought that Time accounts for these things, but I have not looked into it.

[kotp]

So it looks like I have something good to work from, thanks. Though for one, I did get 39 seconds, so that is what got me thinking about the leap seconds that get put into place.

[kytrinyx]

Interesting. I really need to dig into all of this to get a better understanding of it. Time/Date/Timezones always makes me want to hide in a corner somewhere.

[kotp]

Yes, it is definitely not a shallow subject. Should have a pull request for you in a matter of moments.

re: #78

[kotp]

I can't close this, but the pr #78 was merged and I assume this is closed?

[kytrinyx]

Ah, yes. Thanks!