Giter Site home page Giter Site logo

Comments (9)

kotp avatar kotp commented on July 24, 2024

Yes, it is.

But you are a good systems coder, you know this already. In fact, I would be almost surprised if you did not already have a pull request ready.

If you want easy tests running though, I would suggest using guard or some other auto-testing mechanism, then you don't even need to type those 3 characters every time, and that makes running tests extremely easy. (I think you already know this as well.)

from ruby.

arp242 avatar arp242 commented on July 24, 2024

@kotp I am slightly confused by your comment; do you mean "go make a patch!" or "meh; it's not that useful"?

from ruby.

kotp avatar kotp commented on July 24, 2024

Yes, the comment was kind of two sided. If you have a patch ready, I would be interested in seeing it.

But I also think that solving the problem is a great exercise left to each person to solve as they learn more about the language.

from ruby.

kotp avatar kotp commented on July 24, 2024

@Carpetsmoker Any thoughts on what you want to do with this? If a solution will benefit those on [Li|U]n[u|i]x as well as Windows that would be awesome as well.

from ruby.

kotp avatar kotp commented on July 24, 2024

Closed by #155

from ruby.

kytrinyx avatar kytrinyx commented on July 24, 2024

I'd like to revisit this.

Back when it was proposed I said I saw no reason not to include it, however I've later been convinced that it's not really great to give people the habit of executing something they downloaded without checking it first.

There are two parts to this:

  1. When downloading the tests, the CLI will not set the executable bit, so people would have to chmod the file themselves.
  2. Should we remove the shebangs and encourage people to add it themselves if they want to (or use guard)?

from ruby.

arp242 avatar arp242 commented on July 24, 2024

It seems to me that it's merely a convenience matter of typing ruby test_foo.rb vs. ./test_foo.rb. I prefer the latter, as it's not uncommon for me to type python foo.rb or sh foo.py and it works well with tab-completion (You just have to type ./<Tab>, instead of ruby test_<Tab>).

The issue of trusting random files "downloaded from the internet" is not really related to this, IMHO...

Should we remove the shebangs and encourage people to add it themselves if they want to (or use guard)?

The issue is that you need to add it to a lot of files. I never played with Guard, but isn't that a Ruby-only thing? At any rate, I just would prefer to type ./foo.rb; it's nice and simple and doesn't require any setup.

At any rate, it's a small issue...

from ruby.

kytrinyx avatar kytrinyx commented on July 24, 2024

I never played with Guard, but isn't that a Ruby-only thing?

This entire issue is Ruby-only. The test suites were given the #!/usr/bin/env ruby and the files were given the executable bit only in this track.

I don't really care very strongly about this, since I always map the test command to a single keystroke no matter which language I'm working in.

I guess we can leave it as is, but people will have to chmod the file themselves with the new version of the CLI.

from ruby.

kotp avatar kotp commented on July 24, 2024

I noticed it again today as well, in the bin folder that some are and some aren't (executable)t. Different area and different reason to have them.

There is a tool that already makes exercise test files executable in the bin folder.

Where I noticed a discrepancy today is in the bin folder itself. Some are executable, others are not, all have the magic comment.

from ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.