Giter Site home page Giter Site logo

Re-factor Questions about edsl HOT 2 CLOSED

johnjosephhorton avatar johnjosephhorton commented on August 15, 2024
Re-factor Questions

from edsl.

Comments (2)

apostolosfilippas avatar apostolosfilippas commented on August 15, 2024

Some more things @johnjosephhorton

  • It'd be nice to add integration tests for each of the questions that we support.
  • QuestionFunctional and Question.__add__ need work
  • We should be always allowing both {'answer': 1} and {'answer':'1'} to go through
  • Allowing non-responses at the question level feels kind of weird atm. Either allow it and demand all questions to have it, or do it at some other level (survey?)
  • The way i've implemented it, 'comment' is always optional, in that answer validation will go through even if it is missing. We should get consistent here.

Nice to haves:

  • descriptors could be made DRYer/better
  • answer validation could be made DRYer/better

from edsl.

johnjosephhorton avatar johnjosephhorton commented on August 15, 2024

I'm going to close this issue and create a new consolidated issue, as most have been addressed.

from edsl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.