Topic name includes payload

[exploreembedded]

Topic name includes payload

[OllisGit]

@HumamHelfawi : Thx for the hint!

I changed AWS_IOT.cpp as follows, so that the correct topicname is passed to the custom-function:

void iot_subscribe_callback_handler(AWS_IoT_Client *pClient, char *topicName, uint16_t topicNameLen,
        IoT_Publish_Message_Params *params,
		void *pData)
{
	char shortTopic[512];
	strncpy(shortTopic, topicName, topicNameLen);

	if (subApplCallBackHandler != 0) //User call back if configured
		subApplCallBackHandler(shortTopic, params->payloadLen,
				(char *) params->payload);
}

[muneebmalik78]

@OllisGit Thank you for your answer but the shortTopic Contains some Junk Characters at the end which can be avoided by adding following line after strncpy(shortTopic, topicName, topicNameLen);
shortTopic[topicNameLen] = 0;

[gadget-man]

I have the same error - I need to check the topicName as I'm subscribing to multiple topics. Did you find a solution?

[gadget-man]

Found a solution - in your callbackhander, add the following:

int topicNameLen = strlen(topicName);
topicName[(topicNameLen - payloadLen)] = 0;

EDIT: Correction - this doesn't work, because the length of the topicName doesn't get truncated, so it remains the size of the first submission.

[HumamHelfawi]

The original handler

Hornbill-Examples/arduino-esp32/AWS_IOT/src/AWS_IOT.cpp

Line 80 in 1898068

void iot_subscribe_callback_handler(AWS_IoT_Client *pClient, char *topicName, uint16_t topicNameLen,

has topicNameLen parameter which is very important. However, the custom handler does not have this one.
You should edit the the library and add this field for custome handler.

One other note, the library supports only one subscription. If you make another subscription, it will override the old one.

[intelligentandgoodlooking]

@OllisGit Good spotting! I have also implemented your fix
@muneebmalik78 good work on the null terminator. Always have to be careful of strncpy... it will not null terminate if it hits the n'th character.
You have to do it manually, or use:
snprintf(shortTopic, topicNameLen + 1,"%s", topicName);