Comments (4)
return await customKeyGenerator(request)
This fixed it! Many thanks!
from express-rate-limit.
Oh, 🤦 I missed it the first time through. You aren't returning the value:
keyGenerator: async (request) => {
- await customKeyGenerator(request)
+ return await customKeyGenerator(request)
},
Or, the simpler version:
keyGenerator: customKeyGenerator,
from express-rate-limit.
I think this line may be your issue:
const Authorization = req.header('authorization');
Try this instead:
const Authorization = req.headers['authorization'];
(Note: that line appears in both the customKeyGenerator
and the max
functions. You likely want to change both.)
Unless you have some other code that isn't here, req.headers
(plural) is an object with the header names as lower-cased keys. I'm not aware of req.header()
(singular) being a built-in function.
You could also add in some logging just to see what Authorization
, clientId
, etc. is.
from express-rate-limit.
I think this line may be your issue:
const Authorization = req.header('authorization');Try this instead:
const Authorization = req.headers['authorization'];(Note: that line appears in both the
customKeyGenerator
and themax
functions. You likely want to change both.)Unless you have some other code that isn't here,
req.headers
(plural) is an object with the header names as lower-cased keys. I'm not aware ofreq.header()
(singular) being a built-in function.You could also add in some logging just to see what
Authorization
,clientId
, etc. is.
The client ID is parsed from the Authorization and is correctly returned (at least when I log the result from the clientId
variable). It seems to be using my IP rather than the client ID (but is correctly setting the max ratelimit of 1000 [what the client ID has set])
from express-rate-limit.
Related Issues (20)
- ValidationError: The 'X-Forwarded-For' header is set but the Express HOT 2
- I found that this library occasionally works and occasionally doesn't work. HOT 3
- limit is not working , still need to set max HOT 5
- Get Remaining Rate-Limit HOT 3
- ERR_ERL_DOUBLE_COUNT with multiple rate limits HOT 2
- It blocks all IPs instead of blocking each IP HOT 7
- getKey is undefined in Redis Store HOT 9
- Passed options in RateLimitRequestHandler HOT 1
- Install a problem in express5 / express@next HOT 9
- Can't get the correct ip HOT 3
- Ratelimit headers empty while running on Bun v1.0.x HOT 1
- Don't know how to resetKey when user complete captcha HOT 6
- requestWasSuccessful usage doesn't support returning a Promise
- Can't use process.env variables HOT 3
- An option similar to `skip` but which is evaluated after the request has completed HOT 2
- Add Support for Persistent Storage (e.g., Redis) in express-rate-limit HOT 1
- Enhanced Rate Limiting with a retryAfter option and IP Blocking Features for Improved Flexibility HOT 2
- ERR_ERL_CREATED_IN_REQUEST_HANDLER HOT 5
- Allow rate limit configuration dynamic based on request comes in (Saas) HOT 26
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-rate-limit.