Giter Site home page Giter Site logo

Comments (4)

TheCuteFoxxy avatar TheCuteFoxxy commented on June 9, 2024 2
return await customKeyGenerator(request)

This fixed it! Many thanks!

from express-rate-limit.

nfriedly avatar nfriedly commented on June 9, 2024 1

Oh, 🤦 I missed it the first time through. You aren't returning the value:

    keyGenerator: async (request) => {
-      await customKeyGenerator(request)
+      return await customKeyGenerator(request)
   },

Or, the simpler version:

    keyGenerator:  customKeyGenerator,

from express-rate-limit.

nfriedly avatar nfriedly commented on June 9, 2024

I think this line may be your issue:

  const Authorization = req.header('authorization');

Try this instead:

  const Authorization = req.headers['authorization'];

(Note: that line appears in both the customKeyGenerator and the max functions. You likely want to change both.)

Unless you have some other code that isn't here, req.headers (plural) is an object with the header names as lower-cased keys. I'm not aware of req.header() (singular) being a built-in function.

You could also add in some logging just to see what Authorization, clientId, etc. is.

from express-rate-limit.

TheCuteFoxxy avatar TheCuteFoxxy commented on June 9, 2024

I think this line may be your issue:

  const Authorization = req.header('authorization');

Try this instead:

  const Authorization = req.headers['authorization'];

(Note: that line appears in both the customKeyGenerator and the max functions. You likely want to change both.)

Unless you have some other code that isn't here, req.headers (plural) is an object with the header names as lower-cased keys. I'm not aware of req.header() (singular) being a built-in function.

You could also add in some logging just to see what Authorization, clientId, etc. is.

The client ID is parsed from the Authorization and is correctly returned (at least when I log the result from the clientId variable). It seems to be using my IP rather than the client ID (but is correctly setting the max ratelimit of 1000 [what the client ID has set])

from express-rate-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.