Giter Site home page Giter Site logo

Comments (7)

dougwilson avatar dougwilson commented on April 26, 2024

The module.exports is just the default; pass in your filter function as the filter option to the middleware.

But the module.exports override the exports.filter function, so i can't call it in my filter function.

I'm not sure what this means.

from compression.

dougwilson avatar dougwilson commented on April 26, 2024

I think this should help you:

var compression = require('compression')
var express = require('express')

var app = express()

// compress
app.use(compression({filter: function (req, res) {
  if (some_condition) {
    return false // never compress
  } else {
    return compression.filter(req, res) // use default filter
  }
}}))

from compression.

hefangshi avatar hefangshi commented on April 26, 2024
var compression = require('compression');
console.log(compression.filter);

try this please.

the code defined the module.exports after exports.filter, so the exports.filter is undefined.

from compression.

dougwilson avatar dougwilson commented on April 26, 2024

the code defined the module.exports after exports.filter, so the exports.filter is undefined.

ah, I gotcha now. very sorry about that!

from compression.

dougwilson avatar dougwilson commented on April 26, 2024

Ok, looks like it has been that way since the initial commit, which is good, because I can basically fix this as a new feature :)

from compression.

dougwilson avatar dougwilson commented on April 26, 2024

Alright, it's been added :) It hasn't been released just yet, but it'll be in version 1.3.0.

from compression.

hefangshi avatar hefangshi commented on April 26, 2024

Thanks ;) 👍

from compression.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.