Document: Ambiguity in Signature Documentation

[tncbbthositg]

Document: Ambiguity in Signature Documentation

[cryptiklemur]

Documentation also mentions that signed is false by default, but the code defaults it to true

[dougwilson]

Documentation also mentions that signed is false by default, but the code defaults it to true

Can you point me to where in the docs this is to fix it (or make a pr)? This is what I see that readme says:

signed: a boolean indicating whether the cookie is to be signed (true by default).

[cryptiklemur]

https://www.npmjs.com/package/cookie-session

Only seems to show it here. Its correct in github.

[dougwilson]

Hi @aequasi , sorry I let this drop off. The content there was just copy-and-pasted from the cookies module. What I did here to help address was just to remove all the details and let folks refer to the source of the information (cookies) module instead of keeping duplicate information all over the place that will get out-of-sync. That should at least address this specific issue about the cookie-session readme being confusing about the signature. Especially since the user can change the hash algo, so documenting it as specifically SHA1 is also confusing.